Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy phpstan config into tool dir #1482

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

marschattha
Copy link
Member

@marschattha marschattha commented Feb 7, 2025

Similar to eslint, phpstan config files also load dependencies relative to config file path, so we should copy the phpstan configs into tool directory where we install the packages.

Copy link
Contributor

qltysh bot commented Feb 7, 2025

Diff Coverage: The code coverage on the diff in this pull request is 55.6%.

Total Coverage: This PR will not change total coverage.

File Coverage Changes
Path File Coverage Δ Indirect
qlty-check/src/executor/invocation_script.rs -1.4
qlty-config/src/library.rs -0.5
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@marschattha marschattha requested a review from brynary February 7, 2025 18:30
Copy link
Contributor

qltysh bot commented Feb 7, 2025

All good ✅

Copy link
Member

@brynary brynary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the code, but would like to get confirmation from the customer this works before merging

@marschattha
Copy link
Member Author

@marschattha marschattha merged commit b7ea577 into main Feb 7, 2025
11 checks passed
@marschattha marschattha deleted the ma/copy_phpstan_configs_into_tool_dir branch February 7, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants