Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behavior of ignores #1483

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Fix behavior of ignores #1483

merged 1 commit into from
Feb 7, 2025

Conversation

brynary
Copy link
Member

@brynary brynary commented Feb 7, 2025

The Ignore struct is being used for two entirely different purposes. First, it is used for exclude_patterns which filter files out of analysis. Also, it is used for post-processing, to suppress specific issues based on plugin/rule/level filtering.

These two usages have come together in an emergent behavior with a pretty bad bug -- If you have an [[ignore]] block without a file_patterns specifier, it will exclude all files from all analysis.

To fix this properly, this will require some data re-architecture and more tests, but want to get a hotfix out right away.

Copy link
Contributor

qltysh bot commented Feb 7, 2025

Diff Coverage: The code coverage on the diff in this pull request is 100.0%.

Total Coverage: This PR will increase coverage by 0.01%.

File Coverage Changes
Path File Coverage Δ Indirect
qlty-check/src/planner/plugin_workspace_entry_finder_builder.rs 0.7
qlty-config/src/library.rs 0.5
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@brynary brynary merged commit fd779b6 into main Feb 7, 2025
8 checks passed
@brynary brynary deleted the bh-fix-ignore-blocks branch February 7, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant