-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SimpleCov "merged" Coverage format #1493
base: main
Are you sure you want to change the base?
Conversation
7269dbf
to
219262e
Compare
Diff Coverage: The code coverage on the diff in this pull request is 94.5%. Total Coverage: This PR will increase coverage by 0.02%. File Coverage Changes
🛟 Help
|
Co-authored-by: qltysh[bot] <168846912+qltysh[bot]@users.noreply.github.com>
Support for a "merged" simplecov JSON report, which is a format that we have historically supported.
This changeset is larger than initially envisioned in part because the original code used a
Map
data structure to capture coverage results, where the keys were file paths. Because the point of this PR is to support more than 1 coverage report for the same path, I needed to change the structure of the code to use aVec
instead of aMap
.I could have stopped there, but given the fairly good tests, I refactored until the 3 supported SimpleCov formats were a bit more clearly represented in the code.