Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SimpleCov "merged" Coverage format #1493

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

noahd1
Copy link
Member

@noahd1 noahd1 commented Feb 13, 2025

Support for a "merged" simplecov JSON report, which is a format that we have historically supported.

This changeset is larger than initially envisioned in part because the original code used a Map data structure to capture coverage results, where the keys were file paths. Because the point of this PR is to support more than 1 coverage report for the same path, I needed to change the structure of the code to use a Vec instead of a Map.

I could have stopped there, but given the fairly good tests, I refactored until the 3 supported SimpleCov formats were a bit more clearly represented in the code.

@noahd1 noahd1 force-pushed the nd-example-failure branch from 7269dbf to 219262e Compare February 20, 2025 18:10
Copy link
Contributor

qltysh bot commented Feb 20, 2025

Diff Coverage: The code coverage on the diff in this pull request is 94.5%.

Total Coverage: This PR will increase coverage by 0.02%.

File Coverage Changes
Path File Coverage Δ Indirect
qlty-coverage/src/parser/simplecov.rs -0.2
qlty-cloud/src/auth/auth_flow.rs -0.5
qlty-cli/src/ui/unformatted.rs 0.4
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copy link
Contributor

qltysh bot commented Feb 20, 2025

All good ✅

@noahd1 noahd1 changed the title Test failure demonstrating unsupported SimpleCov format Support SimpleCov "merged" Coverage format Feb 20, 2025
@noahd1 noahd1 requested a review from brynary February 20, 2025 20:24
noahd1 and others added 2 commits February 20, 2025 12:54
Co-authored-by: qltysh[bot] <168846912+qltysh[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant