Skip to content

Deprecate override in favour of triage #2005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Deprecate override in favour of triage #2005

wants to merge 4 commits into from

Conversation

marschattha
Copy link
Member

@Copilot Copilot AI review requested due to automatic review settings May 1, 2025 19:49
Copilot
Copilot AI reviewed May 1, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR deprecates the legacy override functionality in favor of a new triage configuration for issue transformation. Key changes include the introduction of the triage module with new configuration structures, removal of unused override logic, and updates to the planner to build triages from both triage and legacy override settings.

Reviewed Changes

Copilot reviewed 7 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
qlty-config/src/config/triage.rs Introduces new triage configuration and implementation.
qlty-config/src/config/overrides.rs Deprecates override functionality by removing redundant code.
qlty-config/src/config.rs Re-exports the new triage components and updates module order.
qlty-cli/tests/cmd/check/triage.toml Adds a test configuration for triage.
qlty-cli/tests/cmd/check/triage.in/.qlty/qlty.toml Updates TOML config to include triage settings.
qlty-cli/tests/cmd/check/override.in/.qlty/qlty.toml Retains a legacy override test configuration with a deprecation notice.
qlty-check/src/planner.rs Modifies the plan builder to prefer triage over override.
Files not reviewed (6)
  • qlty-cli/tests/cmd/check/override.stderr: Language not supported
  • qlty-cli/tests/cmd/check/triage.in/.gitignore: Language not supported
  • qlty-cli/tests/cmd/check/triage.in/sample.sh: Language not supported
  • qlty-cli/tests/cmd/check/triage.in/sample2.sh: Language not supported
  • qlty-cli/tests/cmd/check/triage.stderr: Language not supported
  • qlty-cli/tests/cmd/check/triage.stdout: Language not supported
Comments suppressed due to low confidence (2)

qlty-cli/tests/cmd/check/triage.in/.qlty/qlty.toml:17

  • The key 'match.plugin' does not match the expected field name 'plugins' in the Triage configuration. Consider updating this key to 'plugins' to ensure proper deserialization.
match.plugin = "exists"

qlty-cli/tests/cmd/check/triage.in/.qlty/qlty.toml:18

  • The key 'match.rule' does not match the expected field name 'rules' in the Triage configuration. Please update this key to 'rules' for consistency.
match.rule = "fail"

@qltysh qltysh
Copy link
Contributor

qltysh bot commented May 1, 2025 •
edited
Loading

Diff Coverage for macos-15: The code coverage on the diff in this pull request is 86.5%.

Total Coverage for macos-15: This PR will increase coverage by 0.14%.

File Coverage Changes
Path File Coverage Δ Indirect
qlty-check/src/planner.rs 1.7
qlty-cli/src/auth/auth_flow.rs -0.5 √
qlty-config/src/config/triage.rs 86.3
qlty-config/src/library.rs -0.5 √
qlty-types/src/lib.rs 4.7 √
🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@qltysh qltysh
Copy link
Contributor

qltysh bot commented May 1, 2025 •
edited
Loading

Diff Coverage for ubuntu-latest: The code coverage on the diff in this pull request is 86.5%.

Total Coverage for ubuntu-latest: This PR will increase coverage by 0.14%.

File Coverage Changes
Path File Coverage Δ Indirect
qlty-check/src/planner.rs 1.7
qlty-config/src/config/triage.rs 80.6
qlty-config/src/library.rs -0.5 √
qlty-types/src/lib.rs 4.7 √
🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@qltysh qltysh
Copy link
Contributor

qltysh bot commented May 1, 2025 •
edited
Loading

❌ 1 blocking issue (1 total)

Tool Category Rule Count
ripgrep Lint // TODO: Issues without a path are not filterable 1 ❌

qltysh[bot]
qltysh bot reviewed May 1, 2025
View reviewed changes
qlty-config/src/config/triage.rs
if let Some(path) = issue.path() {
glob_set.as_ref().unwrap().is_match(path)
} else {
// TODO: Issues without a path are not filterable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// TODO: Issues without a path are not filterable [ripgrep:TODO]

@marschattha marschattha requested a review from brynary May 1, 2025 21:09
@marschattha marschattha mentioned this pull request May 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qltysh qltysh[bot] qltysh[bot] left review comments

Copilot code review Copilot Copilot left review comments

@brynary brynary Awaiting requested review from brynary

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marschattha