You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR contains small updates to my personal keymap for the Drop ALT keyboard. Primarily the changes are to enable EEPROM persistence for the RGB mode, to avoid having to reset the RGB pattern every time the board loses power.
It's worth noting that EEPROM is still disabled by default for the Drop ALT, so for this to actually work changes are also needed from #6068 which is unfortunately stuck in limbo.
I'd still like to get these keymap changes into mainline though, as they compile and run fine on their own.
Types of Changes
Core
Bugfix
New feature
Enhancement/optimization
Keyboard (addition or update)
Keymap/layout/userspace (addition or update)
Documentation
Checklist
My code follows the code style of this project: C, Python
ewersp
changed the title
[Keymap] Update keymap to take advantage of EEPROM storage
[Keymap] Update personal Drop ALT keymap to take advantage of EEPROM storage
May 31, 2021
ewersp
changed the title
[Keymap] Update personal Drop ALT keymap to take advantage of EEPROM storage
[Keymap] Updates to personal Drop ALT keymap
May 31, 2021
Just a heads up, the massdrop boards don't officially support eeprom.
Yeah :( I grabbed the updated mdloader from Massdrop/mdloader#49 and modified qmk_firmware\tmk_core\common\arm_atsam\eeprom.c locally to make everything work, but it seems fine (and harmless?)
I just realized some RGB-related changes were made to the default drop alt keymap, so I incorporated those changes into this PR (and removed a legacy hack I had to address the flickering caps lock key which has now been fixed properly).
Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR contains small updates to my personal keymap for the Drop ALT keyboard. Primarily the changes are to enable EEPROM persistence for the RGB mode, to avoid having to reset the RGB pattern every time the board loses power.
It's worth noting that EEPROM is still disabled by default for the Drop ALT, so for this to actually work changes are also needed from #6068 which is unfortunately stuck in limbo.
I'd still like to get these keymap changes into mainline though, as they compile and run fine on their own.
Types of Changes
Checklist