Added support for GMMK3 Pro 75% keyboard#26292
Conversation
|
Hi drashna, thanks for the review. I have followed most of the requested changes, but I found that removing the |
|
Thanks for the review! I have added the changes as requested. Also, I have removed the macro definition with the 2 weird underscores, as it was used by Glorious for the rgb matrix config, which I moved to JSON, so it's not needed anymore. |
zvecr
left a comment
There was a problem hiding this comment.
There are still unresolved suggestions.
Co-authored-by: Joel Challis <git@zvecr.com>
|
My bad, I missed some of the requested changes. They should all be included now. |
|
Yeah, the |
This PR adds support for the GMMK3 Pro 75% keyboard to the main QMK repository.
Description
The GMMK3 Pro 75% keyboard has a current QMK version on Glorious's own repository, but this version is not up-to-date with the current QMK version, and it lacks some features that is presented in the proprietary firmware (such as some key bindings for the Fn layer and the RGB zone changing feature).
This PR adds support for this keyboard to the main QMK repository, including:
keyboard.json.I have tested this PR with my own keyboard, which is the ANSI version. The ISO version was updated in a similar way, but I don't have the ISO keyboard to test. Also, my apologies for having everything in one single commit. I did it in multiple commits, but messed up my commit author name and email, so I had to re-forked and copied-pasted the new files.
Please let me know if I need to fix anything. Thanks!
Types of Changes
Issues Fixed or Closed by This PR
N/A
Checklist