Make framebuffer effects honour rgb_matrix_map_row_column_to_led

[zvecr]

Description

rgb_matrix_map_row_column_to_led handles the mapping of multiple LEDS to a single matrix position. This was missing from typing heatmap, and only partially implemented in digital rain.

Typing heatmap should also handle NO_LED better as g_led_config.flags[g_led_config.matrix_co[row][col]] could index out bounds g_led_config.flags when g_led_config.matrix_co[row][col] returns NO_LED (255).

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout (addition or update)
• Documentation

Issues Fixed or Closed by This PR

Checklist

• My code follows the code style of this project: C, Python
• I have read the PR Checklist document and have made the appropriate changes.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[drashna]

Something about this change breaks those animations, at least for split boards.

[zvecr]

I cant see how it would have broken digital rain, given it would have the same behaviour when there are no duplicate matrix entries in the LED config.

The "decrease heatmap" logic was running too frequently so that should now be fixed.

Can you be a bit more descriptive about it "breaking" so it rules out the above?

[drashna]

naturally, I can't reproduce now. :( Might have been a hardware issue, on my end.