Skip to content

[CLEAN] Synthetic Benchmark PR #24640 - fix: allow org admin to cancel and reschedule seated bookings#21

Closed
tomerqodo wants to merge 1 commit into
base_pr_24640_20251106_1955from
clean_pr_24640_20251106_1955
Closed

[CLEAN] Synthetic Benchmark PR #24640 - fix: allow org admin to cancel and reschedule seated bookings#21
tomerqodo wants to merge 1 commit into
base_pr_24640_20251106_1955from
clean_pr_24640_20251106_1955

Conversation

@tomerqodo

Copy link
Copy Markdown

Benchmark PR calcom#24640

Type: Clean (correct implementation)

Original PR Title: fix: allow org admin to cancel and reschedule seated bookings
Original PR Description: ## What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Summary by cubic

Allow org admins and owners to reschedule and cancel seated bookings for users in their org and sub-teams. Centralized the org admin check and fixed the confirmation message text.

  • Bug Fixes

    • Permit cancellation and rescheduling when the requester is an org admin/owner of the booking host.
    • Return the correct "seatUid required" error for seated bookings unless an org admin reschedules all seats.
    • Correct confirmation message to "Booking confirmed"/"Booking rejected".
  • Refactors

    • Moved org admin logic to PrismaOrgMembershipRepository and reused across API/TRPC.
    • Simplified reschedule flow to detect individual-seat vs org-admin all-seat requests.

Written for commit 202d468. Summary will update automatically on new commits.

Original PR URL: calcom#24640

@github-actions

github-actions Bot commented Nov 6, 2025

Copy link
Copy Markdown

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "[CLEAN] Synthetic Benchmark PR #24640 - fix: allow org admin to cancel and reschedule seated bookings". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@tomerqodo tomerqodo closed this Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant