feat: allow pass hostname in docker env - #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR from qodo-benchmark#419
Note
Adds optional hostname override for SMTP HELO/EHLO and propagates it through configuration and runtime.
SMTP_LOCAL_HOSTNAMEinMailConfigand documented inapi/.env.example, integration test.env.example, anddocker/.env.exampledocker-compose.yamlpassesSMTP_LOCAL_HOSTNAMEto the API serviceSMTPClient.sendnow setslocal_hostnamewhen creatingsmtplib.SMTP/SMTP_SSLand uses it forEHLOin STARTTLS flowlocal_hostnameparameter (ANY) in SMTP constructorsWritten by Cursor Bugbot for commit 3e5625b. Configure here.