feat: unified management stop event - #6
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| worker_id=worker_id, | ||
| flask_app=self._flask_app, | ||
| context_vars=self._context_vars, | ||
| stop_event=self._stop_event, |
There was a problem hiding this comment.
Worker scale-down fails because stop() is now no-op
Medium Severity
The _remove_worker method calls worker.stop() expecting it to stop an individual worker during scale-down operations. However, Worker.stop() is now a no-op that does nothing since workers now rely on a shared stop_event from GraphEngine. This means _try_scale_down will fail to actually stop workers — the join(timeout=2.0) will always timeout and the worker thread continues running in the background, defeating dynamic scaling and causing resource waste.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR from qodo-benchmark#171
Note
Centralizes execution stop control via a shared
threading.Eventmanaged byGraphEngine, improving coordinated shutdown and cancellation.stop_eventinGraphEngine; clear on start and set on stop; attach toGraphRuntimeStateand pass to subsystemsstop_event(remove internal one); reducejointimeout to 2sstop_eventtoWorker; makeWorker.stop()a no-op; pool stops by joining workers (2s) without per-worker stop signaling_should_stop()in baseNodeand check between yields; emitNodeRunFailedEventwith "Execution cancelled" on stopstop_eventfield toGraphRuntimeStatetest_stop_event.pyand updates to dispatcher tests validating propagation, resume behavior, and shorter timeoutsWritten by Cursor Bugbot for commit ef61c4b. Configure here.