Calls order of q_invokable method #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
David Boddie seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
* Make nonstandard RESOURCE_PREFIXes explicit * Add TEST_PLUGIN to MockExtensionPlugin * Remove lint target from intentionally hidden module Also remove some useless VERSION statements and an ineffective QTP0001. Change-Id: Iadbacce55810bdbb2cbc6a1c7175303b96e06120 Reviewed-by: Sami Shalayel <[email protected]> Reviewed-by: Fabian Kosmale <[email protected]>
There's no Details section for qmlformat, so it ends up actually linking to the Details section of qmlpreview ... Pick-to: 6.10 Change-Id: Ib6142b362b15a72ef847bb6e751cf64bd64a9e04 Reviewed-by: Fabian Kosmale <[email protected]>
This implements support for the <symbol> tag, which is like a definition node, but which defines its own coordinate system (viewbox) to make it more reusable. Fixes: QTBUG-121539 Change-Id: I5fef5ad264511bc72ff40e66cfd0c6091812b015 Reviewed-by: Hatem ElKharashy <[email protected]> Reviewed-by: Eirik Aavitsland <[email protected]>
case conversions are now separate from other properties. See commit 763f19151cc31ca1ba4912e0828359be5dba89e8 in qtbase. Pick-to: 6.10 6.8 6.5 Change-Id: Ia13f515e613c7470f816c9930e870e391c88e367 Reviewed-by: Marc Mutz <[email protected]>
* Re-arrange and add section headers to adhere to the app template. * Replace first-person plural (we) with either third-person singular (the example) or second-person singular (you). * Add qdoc links to C++ or QML entities. Fixes: QTBUG-137898 Pick-to: 6.10 6.9 6.8 Change-Id: Ib61ca9beac1bafb4e4e5f8fcc6475093b313768e Reviewed-by: Jerome Pasion <[email protected]>
These snippets show up in the Qt Quick States documentation. Fixes: QTBUG-140487 Pick-to: 6.10 Change-Id: I897865e16a356c1c561715adc4daa97a4bd3dd67 Reviewed-by: Mitch Curtis <[email protected]>
By not comparing the Dial's value against 1 eight times. Amends 42687ca. Pick-to: 6.8 6.10 Change-Id: I67bc64c517d06a176ba4b2189f5755f954915ae1 Reviewed-by: Oliver Eftevaag <[email protected]>
- Move exclusions common to all tests into a variable that we can reuse - Keep one entry per line to keep git blame useful - Sort entries alphabetically Pick-to: 6.10 Change-Id: Ib4bd520339d5378ee74b82e414bf994b321d8c7b Reviewed-by: Oliver Eftevaag <[email protected]>
- Move exclusions common to all tests into a variable that we can reuse - Keep one entry per line to keep git blame useful - Sort entries alphabetically Pick-to: 6.10 Change-Id: I28f2816e3431bb7ca22f6d8a019354a4282fded1 Reviewed-by: Oliver Eftevaag <[email protected]>
Followup to a6b55b3c46cf47d560e10a4b69db24a475261546 Change-Id: If35cb2b3ab5654549e76fc18ad094acdc7a832eb Reviewed-by: Shawn Rutledge <[email protected]> Reviewed-by: Eirik Aavitsland <[email protected]>
It more acurately captures what the flag means. Change-Id: I638f03fcdcbe48cb464c615e26ee396f8959d63f Reviewed-by: Sami Shalayel <[email protected]>
SearchOptions is being default constructed in several places. The constructors need to be out of line because otherwise they are not yet available before the end of the outer class. Amends e3891d7 Change-Id: I7fe09afda75d9d75d19d94fda7bf73fdfe014a1b Reviewed-by: Ulf Hermann <[email protected]>
This can help users identify typos in section names such as [Warning] -> [Warnings]. Change-Id: I6984c3b5f3f06b8a393f83b951f47b05b5565efd Reviewed-by: Ulf Hermann <[email protected]>
It gets called again for every file anyway and may actually cause issues by overriding previous changes made to categories. Change-Id: I9ed4444f2bf2012a19dfdacd7fe0798faa5942f6 Reviewed-by: Sami Shalayel <[email protected]>
Task-number: QTCREATORBUG-33305 Change-Id: I9e23a755da0354ab1d64b7f50ff6f9cc7acbe85a Reviewed-by: Sami Shalayel <[email protected]>
It's moved to qtdoc module Change-Id: Iae61a9aebc45eaf661e393f8d587ec3c8f0cc6a9 Reviewed-by: Tor Arne Vestbø <[email protected]>
Change-Id: Ic4def3b9649cf369be97b18cf7916ddef4ee5ade Reviewed-by: Shawn Rutledge <[email protected]>
uiLanguage is a property of QJSEngine, not QQmlEngine. Pick-to: 6.5 6.8 6.10 Change-Id: Id865f969119d8a5aef2e46d1b673db97da6e40f9 Reviewed-by: Ulf Hermann <[email protected]>
Change-Id: I4dbd22b76d1a6e1d9029a3b0bd454e7bdf1dd526 Reviewed-by: Qt Submodule Update Bot <[email protected]>
Introduce new QAccessibleQuickTextEdit as a11y implementation for QQuickTextEdit. Subclass the existing QAccessibleQuickItem and override the methods to modify text selection. (For retrieving the existing selection, the logic in the base class is fine, but the TextEdit properties selectionStart and selectionEnd are read-only, so cannot be set directly there.) Implement the QAccessibleTextInterface::addSelection logic in the base class, so it can also be reused by the QAccessibleQuickTextInput class that will be added in an upcoming commit to implement similar logic for QQuickTextInput and QQuickTextField. Extend the existing unit test to also test text selection. Task-number: QTBUG-139943 Pick-to: 6.10 6.9 6.8 Change-Id: Ibd6aa3e1bc9a24352c9bef4fcf4a452252d6689c Reviewed-by: Timon Sassor <[email protected]> Reviewed-by: Morten Johan Sørvig <[email protected]>
So far, accessibility logic was implemented in QQuickTextField, while its base class QQuickTextInput didn't have any implementation. Most of the existing logic only requires QQuickTextInput(Private), however. Move that logic to the QQuickTextInput(Private) base class and only leave the QQuickTextField-specific logic in the subclass. Task-number: QTBUG-139943 Fixes: QTBUG-140441 Change-Id: I757222a7b6c21b575bfe404333cc7ed91af86ed7 Reviewed-by: Morten Johan Sørvig <[email protected]>
Similar to the previous commit that introduced QAccessibleQuickTextEdit, introduce QAccessibleQuickTextInput and implement the logic to modify selection. This allows changing the selection for QQuickTextInput and its QQuickTextField subclass via the platform accessibility API, e.g. the AT-SPI Text interface's SetSelection method. Extend the existing TextInput autotest accordingly. Task-number: QTBUG-139943 Task-number: QTBUG-140441 Change-Id: Ie05c6b0cf3431aabb4b337dbfa07c40c56660e2b Reviewed-by: Timon Sassor <[email protected]> Reviewed-by: Morten Johan Sørvig <[email protected]>
Use Popup.Item popupType when test is run on Wayland. Remove the need for a transient parent on Wayland that was causing several tests of tst_QQuickTextField to consistently fail. Fix the following failing tests on Ubuntu 24.04 wayland tst_QQuickTextField::contextMenuCopy, contextMenuCut, contextMenuDelete, contextMenuPaste, contextMenySelectAll, releaseAfterPressAndHold, touchscreenDoesNotSelect. Pick-to: 6.10 Change-Id: I5a411dae63ae36361ed83055a1eb4c87de17acae Reviewed-by: Mitch Curtis <[email protected]>
The qml-i18n example and the qtdeclarative repo itself depend on the LinguistTools CMake package, which is not available while building qtdeclarative. This results in: - missing build coverage for the example - a cyclic dependency, because qtdeclarative depends on qttools (because of LinguistTools), and qttools depends on qtdeclarative (because of qdoc needs) - we try to find a module that will never be available, unless qtdeclarative is built together with qttools in a top-level build - in certain cases, if the top-level build fails early enough, the cyclic dependency causes reconfigurations to fail Remove the example, the lookup of LinguistTools, and the linguist doc references to avoid all these issues. Replace the qt_add_translations reference in the docs of the QQmlApplicationEngine class with a snippet copy. Pick-to: 6.8 6.10 Task-number: QTBUG-141465 Change-Id: Id88603a3753f53dfac9f350e981073effda15eb1 Reviewed-by: Masoud Jami <[email protected]>
Test is failing when the movingSpy.Size is checked before the dragging had time to actually be completed. Slightly increase the timeout period on QTRY_COMPARE when verifying movingSpy.Size. Previously QTRY_COMPARE would be trying for 1000 ms, increase the timeout to 2000 ms to ensure that the pathview has finished being dragged. Change-Id: Ie28225067231dd523ef8136246c2796a2fe54cfa Reviewed-by: Mitch Curtis <[email protected]>
This patch introduces a new styling API for Controls called StyleKit. StyleKit provides a higher-level, key–value–based approach to styling applications, serving as an alternative to working directly with the lower-level Templates API. The primary goal of StyleKit is to offer a unified API for styling both Controls and Widgets. The current Templates-based approach relies heavily on JavaScript, which makes it unsuitable for use with Widgets. This initial version supports Controls only; support for Widgets will be added in a future update. StyleKit is designed to make it easier for designers and UI developers to: - Focus on visual styling rather than Template logic (such as geometry, delegate positioning, and handle placement). - Allow style properties to propagate, enabling you to factor out common styling into shared control types and override only what differs in the more specific control types. - Style controls independently in each of their states, without needing nested ternary expressions to check state. - Define and apply multiple themes with minimal effort. - Provide different style variations depending on context. For example, styling a Switch differently when it appears inside a ToolBar. [ChangeLog][Qt labs] Introduced new QML module 'StyleKit'. StyleKit provides a flexible styling framework for Qt Quick Controls, enabling developers to define reusable styles and themes using a simple key-value property format. Change-Id: Iae25324486aea7a7b9b2ce52135327ec7e9b6f59 Reviewed-by: Mitch Curtis <[email protected]>
This patch will add a new example to Controls that demonstrates the new StyleKit API that has recently been added to Qt.labs. It contains a few styles that the user can choose between, where each style has a different level of complexity. Change-Id: Ie193105c05759eee2b4f4deb9d1932448d7e36c5 Reviewed-by: Doris Verria <[email protected]>
This patch introduces 'virtual' and 'override' keywords. From the grammar perspective they are qml contextual keywords, first of all to preserve backwards compatibility (do not break the users code if they had object attributes named "virtual" or "override") "final" is made qml contextual keyword for the sake of consistency (to treat all "virt specifiers" equally) Change-Id: Ice13a77c8b54ce8219cd45cc7085fb3f10a5e908 Task-number: QTBUG-98320 Reviewed-by: Ulf Hermann <[email protected]> Reviewed-by: Sami Shalayel <[email protected]>
Add const references to the loops to avoid copies. Change-Id: I08cfc615d5a40e88a41de23750a0416b6309b1dc Coverity-Id: 897432 Coverity-Id: 897433 Reviewed-by: Ulf Hermann <[email protected]>
Don't take unnecessary temporaries and move values into place. Change-Id: I2b871c365e068a8665c03497f72b91106001a0cd Reviewed-by: Sami Shalayel <[email protected]>
This will match them with Q4A. Task-number: QTBUG-138877 Pick-to: 6.10 Change-Id: Ia5cb1954b361f7f0abb788c326045f71da202607 Reviewed-by: Assam Boudjelthia <[email protected]>
Change-Id: Ic9eeeb5658f9f6251191406a68649705b6389b55 Reviewed-by: Qt Submodule Update Bot <[email protected]>
This patch will add support for Instance Variations. Instance Variations allows you to define one or more style variations in a StyleKit style that can be activated from the application using an attached 'StyleKitControl.variations' object. Instance Variations will affects all descendant StyleKitReaders of the item that contains the attached object. For example, if you set "StyleKitControl.variations: ['mini']" on a GroupBox, all controls inside that GroupBox will be affected with the variation named "mini" in the style (if any). Inside a variation, you specify which controls should receive alternative styling when the variation is applied. Any properties defined in a Variation override those set in the Style or Theme. In order to support Instance Variations, this patch will also refactor how we implement Type Variations, which are variations that applies to _all_ controls of a specific type, rather than to individual instances. Change-Id: I6486979281997e69b65da0ed4866b264c91c592f Reviewed-by: Doris Verria <[email protected]>
macOS 26 (Tahoe) changed NSSearchFieldCell: the magnifying glass icon is taller. Drawing it at the button's full rect causes the top to be clipped by the bezel, though the clear icon remains fine. To avoid this, we render the search icon at a fixed, smaller size to prevent upscaling and eliminate clipping after 26.0. Fixes: QTBUG-141776 Pick-to: 6.10 Change-Id: Ifb5f4476253e55e700b8b89e864afdbb2ceedd8f Reviewed-by: Richard Moe Gustavsen <[email protected]>
They need to link the styles they import so that the dependencies are clarified (and also they'll in fact need the linkage if we ever compile them in direct mode). Pick-to: 6.10 Task-number: QTBUG-137440 Change-Id: I6edaba4390dce4f9cc2b95586f28331192cc01ff Reviewed-by: Mitch Curtis <[email protected]> Reviewed-by: Alexandru Croitor <[email protected]>
We need strong references for the cases where we place guards on the stack to prevent the deletion of the objects, and weak references we hand out to the view. The views don't systematically track the objects they hold and generally use a QPointer as second line of defence. In certain cases we cannot avoid deleting objects that are in fact still referenced as the clearObjectWeakReferences() call shows. If the QQmlDelegateModel itself is deleted while some view still holds a weak reference to an object, we cannot avoid deleting that object, no matter if the view agrees. Also, we can do with 16bit numbers for the references. The guards on the stack are rather few and you'll overflow the stack before you hit the 16bit maximum. The references handed out to the views are generally one or two per item. Task-number: QTBUG-141963 Change-Id: Ifb79e993abcaf4c169b08641ebc2a6378e0a4776 Reviewed-by: Fabian Kosmale <[email protected]>
There are cases, such as Item2D in QtQuick3D, where a Qt Quick user interface is not placed directly inside a QWindow. In that case, Menu and other Popup items need to be shown in the context of the toplevel Item rather than the window. There are two separate Popup implementations: A popup can either be a toplevel window known to the windowing system, or it can be an Item that lives in a special Overlay layer, which normally fills the entire window. This change adds private C++ API in QQuickItemPrivate to add a custom Overlay to an Item. This does not in any way affect the case where a popup has its own toplevel window. Task-number: QTBUG-142145 Change-Id: Ic96a450f6d47e43d1ffc8226b27c1dc5d62e3497 Reviewed-by: Oliver Eftevaag <[email protected]> Reviewed-by: Shawn Rutledge <[email protected]>
It only calls dvValue(). Replace all usages, and change the second argument to use PathEls::Field(). This helps unclutter the DomItem interface. Task-number: QTBUG-142187 Change-Id: If32856e115528c1c0f8db737e8c7c78d3912c233 Reviewed-by: Semih Yavuz <[email protected]>
It only calls dvItem(). Replace all usages, and change the second argument to use PathEls::Field(). This helps unclutter the DomItem interface. Task-number: QTBUG-142187 Change-Id: Ieb14e4cf1d542ba257ec3d23b290504148cbf5ed Reviewed-by: Semih Yavuz <[email protected]>
It only calls wrap(). Replace all usages, and change the first argument to use PathEls::Field(). This helps unclutter the DomItem interface. Task-number: QTBUG-142187 Change-Id: I3aeda82b95948dde7bb7b07ab573585ac11958a6 Reviewed-by: Semih Yavuz <[email protected]>
It only calls its first argument with the two other arguments, and does not use this. Remove it and replace all usages with a direct call. Task-number: QTBUG-142187 Change-Id: Icb42f38199803ee5c1fac1636d10430e7385551b Reviewed-by: Semih Yavuz <[email protected]>
dvValue is not really expressive, rename it to show that it calls the visitor argument on a value-wrapped version of its value argument. Task-number: QTBUG-142187 Change-Id: I95e37f72e8596185294ecf92452b6925eb17e606 Reviewed-by: Semih Yavuz <[email protected]>
dvWrapField is not really expressive, rename it to show that it calls the visitor argument on a field-wrapped version of its field argument. Task-number: QTBUG-142187 Change-Id: Ied467d5fa857934dea069982672f313cd961eb67 Reviewed-by: Semih Yavuz <[email protected]>
dvReferenceField is not really expressive, rename it to show that it calls the visitor argument on a reference-wrapped version of its reference argument. Task-number: QTBUG-142187 Change-Id: I2ceb90b63e3e63bb4acd9f5d19278eddf1a51a3a Reviewed-by: Semih Yavuz <[email protected]>
dvValueLazyField is not really expressive, rename it to show that it calls the visitor argument on a field-wrapped version of its lazy field argument. Task-number: QTBUG-142187 Change-Id: I96b065a55257e62d5d6b970a5487c33b389a0b04 Reviewed-by: Semih Yavuz <[email protected]>
Pick-to: 6.10 6.8 6.5 Change-Id: I1bd30625e474ea4e36c6fb252afbbe2cd9e17162 Reviewed-by: Ulf Hermann <[email protected]>
Change-Id: I3dbd469b26914b0380bb781c1c2993a43657bd4e Reviewed-by: Ulf Hermann <[email protected]>
Lottietoqml and the corresponding VectorImage backend are no longer in tech preview in Qt 6.11. Change-Id: I73647ff0d1df263b314b0535d988823b44afa34b Reviewed-by: Eirik Aavitsland <[email protected]>
It uses FolderListModel. Pick-to: 6.10 Task-number: QTBUG-137440 Change-Id: I44cc4f312dddde756bbb33aa7a564c1c4085c75e Reviewed-by: Alexandru Croitor <[email protected]> Reviewed-by: Sami Shalayel <[email protected]>
You can call splice with only one argument, after all. Pick-to: 6.10 6.8 6.5 Fixes: QTBUG-142253 Change-Id: I3dec244325fd4d57a045ec024968e26e4f6372db Reviewed-by: Olivier De Cannière <[email protected]> Reviewed-by: Fabian Kosmale <[email protected]>
Change-Id: Ic2bb88c34938dda87864094595de8b7553d9508e Reviewed-by: Qt Submodule Update Bot <[email protected]>
Add a test to avoid QTBUG-142025 from regressing, and log a message with qInfo() when receiving EOF to simplify debugging qmlls in the future. This should help to tell if qmlls stopped on start because of QTBUG-142025 or other reasons (invalid signature, or the qmlls client trying to spawn qmlls from a filepath that does not exist for example). The actual fix of QTBUG-142025 is in qtbase and tracked via QTBUG-142041. Fixes: QTBUG-142025 Pick-to: 6.10 Change-Id: I9cd215ac02e23a1d833755eda058d72622de7318 Reviewed-by: Fabian Kosmale <[email protected]>
Now that qmlls uses the same import paths as qmllint, we warn multiple times if the import paths are bad, once in the qmlls.build.ini generation code and once in the linting target creation part. Add a target property to avoid warning multiple times. Change-Id: If427e17dbf4e21cb0121bf2acced9dccb228e221 Reviewed-by: Alexandru Croitor <[email protected]>
Implement Utils::shiftHighlights to apply diffs to cached highlights. Fallback to shifted highlights when DOM is invalid to avoid recompute. Refactor handlers to use shifted tokens and update result IDs and cache. Add unit tests and invalid fixtures covering deletions and partial edits. Task-number: QTBUG-140645 Change-Id: Ic230af0e3d995e85959beee3dfa37a987843c119 Reviewed-by: Sami Shalayel <[email protected]>
Add a fonts property to the style that allows you to set fonts per control, similarily to what we do in QQuickTheme. The fonts are propagated from the style to the theme, and from the fallback style to the style. That means that if a font is not set for a theme or style, it will be resolved against its fallback font. Since both the QQStyleKitTheme and QQStyleKitStyle should have a fonts property, introduce a common base class: QQStyleKitThemeProperties that contains the fonts property. Later, the palettes can be moved there as well. Also add a font property to the QQStyleKitReader that is suposed to return the font for the current control being read. Change-Id: I116c1ab9bc426570756476ee409513587c475a0d Reviewed-by: Richard Moe Gustavsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are 2 or more methods with the same name but reciving diferent arguments the QJSEngine Pickup the First One declared.
Example:
methodxyz(string)
methodxyz(objptr*)
It picks up the first one passing as argument a string and not the one that i was expecting an object as it was send.