ci: Use docker action to clone repo #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can use the docker/build-push-action with the 'context' input to clone the repo for us. Also rename the action to reflect the primary purpose of "build" instead of "pull" and update the inputs. Signed-off-by: Nasser Grainawi <[email protected]>
|
@quic-viskuma can you review please? |
LGTM |
| default: kmake-image:latest | ||
| image_context: | ||
| description: The context to use for the image build. Likely a git repo URL. | ||
| required: true |
There was a problem hiding this comment.
can we make it required false? we can use the default value for now
There was a problem hiding this comment.
Using required=true is fine as I just learned that GitHub doesn't actually do any enforcement on required. But if they did ever implement it (it's been 5+ years since users asked for it...), I would expect that required=true with a default should still work.
quic-viskuma
force-pushed
the
main
branch
5 times, most recently
from
dbf4b91 to
df6efde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use the docker/build-push-action with the 'context' input to clone the repo for us.
Also rename the action to reflect the primary purpose of "build" instead of "pull" and update the inputs.