Skip to content

Conversation

@WeiDeng-weiden
Copy link

Enable as modules the BT_BNEP and BT_RFCOMM drivers which are required for Bluetooth profiles such as PAN and SPP. Without these modules, PAN and SPP functionality will not be available. Enable UHID support to allow HID over GATT operations. Without this, user-space cannot create virtual HID devices, which impacts HID profile usage over Bluetooth.

Copy link
Contributor

@lumag lumag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/ config//

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Test run workflow

Test jobs for commit 7ff739f

@test-reporting-app
Copy link

Test Results

 14 files  ±0   27 suites  ±0   43m 19s ⏱️ -40s
 52 tests ±0   48 ✅ ±0  0 💤 ±0  4 ❌ ±0 
299 runs   - 1  295 ✅  - 1  0 💤 ±0  4 ❌ ±0 

For more details on these failures, see this check.

Results for commit 7ff739f. ± Comparison against base commit 35ea1c3.

@WeiDeng-weiden
Copy link
Author

s/ config//

Thanks for the review.

For the comment s/ config//, could you please clarify which config you would like me to remove?

@lumag
Copy link
Contributor

lumag commented Dec 4, 2025

s/ config//

Thanks for the review.

For the comment s/ config//, could you please clarify which config you would like me to remove?

I see only one place where the regexp is applicable.

@WeiDeng-weiden
Copy link
Author

s/ config//

Thanks for the review.
For the comment s/ config//, could you please clarify which config you would like me to remove?

I see only one place where the regexp is applicable.

Here is my current diff:
Could you please point out the exact line (file and line number) where you’d like me to remove config, or let me know if this comment can be ignored with the latest patch set?

diff --git a/recipes-kernel/linux/linux-qcom-next/configs/qcom.cfg b/recipes-kernel/linux/linux-qcom-next/configs/qcom.cfg
index b5a294f..837a6aa 100644
--- a/recipes-kernel/linux/linux-qcom-next/configs/qcom.cfg
+++ b/recipes-kernel/linux/linux-qcom-next/configs/qcom.cfg
@@ -308,3 +308,11 @@ CONFIG_NFT_TPROXY=m
CONFIG_NFT_TUNNEL=m
CONFIG_PACKET_DIAG=y
CONFIG_VETH=m
+
+# Enable BT_RFCOMM, BT_BNEP and UHID
+CONFIG_BT_BNEP=m
+CONFIG_BT_BNEP_MC_FILTER=y
+CONFIG_BT_BNEP_PROTO_FILTER=y
+CONFIG_BT_RFCOMM=m
+CONFIG_BT_RFCOMM_TTY=y
+CONFIG_UHID=m

@lumag
Copy link
Contributor

lumag commented Dec 4, 2025

s/ config//

Thanks for the review.
For the comment s/ config//, could you please clarify which config you would like me to remove?

I see only one place where the regexp is applicable.

Here is my current diff: Could you please point out the exact line (file and line number) where you’d like me to remove config, or let me know if this comment can be ignored with the latest patch set?

You've posted a diff, but it's not a full patch. There is an extra " config" in the commit subject.

@WeiDeng-weiden
Copy link
Author

s/ config//

Thanks for the review.
For the comment s/ config//, could you please clarify which config you would like me to remove?

I see only one place where the regexp is applicable.

Here is my current diff: Could you please point out the exact line (file and line number) where you’d like me to remove config, or let me know if this comment can be ignored with the latest patch set?

You've posted a diff, but it's not a full patch. There is an extra " config" in the commit subject.

OK, will remove config in the commit subject.

Enable as modules the BT_BNEP and BT_RFCOMM drivers
which are required for Bluetooth profiles such as PAN
and SPP. Without these modules, PAN and SPP functionality
will not be available. Enable UHID support to allow HID
over GATT operations. Without this, user-space cannot
create virtual HID devices, which impacts HID profile
usage over Bluetooth.

Signed-off-by: Wei Deng <[email protected]>
@WeiDeng-weiden WeiDeng-weiden changed the title linux-qcom-next config: Enable BT_RFCOMM, BT_BNEP and UHID linux-qcom-next: Enable BT_RFCOMM, BT_BNEP and UHID Dec 4, 2025
@ricardosalveti
Copy link
Contributor

Please rebase, build failure is related to the mesa updates (fixed in master).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants