feat(slider): Angular version + thumb indicator #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olaf Kappes <[email protected]>
olaf-k
force-pushed
the
olaf/slider-angular
branch
from
dfebfcf to
bae00c0
Compare
Signed-off-by: Ryan Bower <[email protected]>
…leanup Signed-off-by: Ryan Bower <[email protected]>
R-Bower
requested changes
Nov 16, 2025
Contributor
R-Bower
left a comment
R-Bower
left a comment
There was a problem hiding this comment.
Everything looks good, apart from the tooltip.
Component reuse is ok so long as it doesn't negatively impact the user experience. imo our tooltip is not built for rapid updates, so it's not a good fit for input components like the slider.
slider-tooltip.mp4
compare this to Chakra's, which uses simple CSS for positioning:
chakra-tooltip.mp4
Signed-off-by: Ryan Bower <[email protected]>
Signed-off-by: Ryan Bower <[email protected]>
Signed-off-by: Olaf Kappes <[email protected]>
Signed-off-by: Olaf Kappes <[email protected]>
Signed-off-by: Olaf Kappes <[email protected]>
Signed-off-by: Olaf Kappes <[email protected]>
olaf-k
changed the title
Member
Author
the (actual) Tooltip has been replaced by a new Thumb Indicator subcomponent (React + Angular). it is a port of zag's Dragging Indicator but renamed (as it also appears on hover now) and modified to rely mostly on CSS (the machine is still positioning it). styles are copy/pasted from the Tooltip and doc updated. |
Signed-off-by: Olaf Kappes <[email protected]>
Signed-off-by: Olaf Kappes <[email protected]>
R-Bower
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #36 - migrated from fork branch