Skip to content

General code improvements #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 7, 2018
Merged

General code improvements #164

merged 5 commits into from
Nov 7, 2018

Conversation

@Trybnetic
Copy link
Member

@Trybnetic Trybnetic commented Nov 7, 2018 •
edited
Loading

This PR includes some of the changes @dekuenstle suggested in #160 which should directly go into master.

These are especially:

  • Improvement of the sysinfo() function
  • additional exceptions
  • general code improvements
  • Configure tests in conftest.py

derNarr
derNarr approved these changes Nov 7, 2018
View reviewed changes
Copy link
Member

@derNarr derNarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 83.147% when pulling 0a25075 on generalCodeImprovements into 359ee9f on master.

@Trybnetic Trybnetic merged commit a0bd5e5 into master Nov 7, 2018
@Trybnetic Trybnetic deleted the generalCodeImprovements branch November 7, 2018 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derNarr derNarr derNarr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Trybnetic @coveralls @derNarr @dekuenstle