Addressing issue #336 #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added code to address issue quantopian#336. link: quantopian#336
Added code to address issue quantopian#336 Link: quantopian#336
|
@jimportico Looks great, thanks for contributing this! Seems like our travis CI is broken, did you run the test suite to make things everything still passes? |
|
Hi @twiecki - I checked travis CI and see four failure messages that I'm having a difficulty reconciling. Build Jobs:
I saw something similar on PR #346. That looked unrelated to the changes being submitted. Is that the case for mine as well? |
|
Yeah those are unrelated, just wanted to make sure they did pass with a
functioning setup.
…On Wed, Jan 15, 2020, 00:50 jimportico ***@***.***> wrote:
Hi @twiecki <https://github.com/twiecki> - I checked travis CI and see
four failure messages that I'm having a difficulty reconciling.
Build Jobs:
- 630.1: The command "python setup.py install" failed and exited with
1 during .
- 630.2, 630.4, & 630.5: The command "conda create -q -n testenv --yes
python=$TRAVIS_PYTHON_VERSION ipython flake8 numpy scipy nose matplotlib
pandas=$PANDAS_VERSION statsmodels seaborn" failed and exited with 1 during
.
I saw something similar on PR #346
<#346>. That looked unrelated
to the changes being submitted. Is that the case for mine as well?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#354?email_source=notifications&email_token=AAFETGH46ZWE7MCG5GK6G7TQ5ZFVVA5CNFSM4KFMJNHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI6RNSQ#issuecomment-574428874>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFETGBFG4GIW76MRHIJJMTQ5ZFVVANCNFSM4KFMJNHA>
.
|
|
Thanks @jimportico! |
|
If you want, in a separate PR you could add a unittest to make sure the feature works as desired. |
|
Thanks @twiecki - happy to help! I haven't submitted a unittest for an OSS project before but would like to learn more. Do you have a sample you can point me toward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to address issue #336.
link: #336