Skip to content

WebSockets Next: support OpenTelemetry's SpanAttribute annotation placed on endpoint callback arguments #50714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mkouba merged 1 commit into from
Oct 29, 2025
Merged

WebSockets Next: support OpenTelemetry's SpanAttribute annotation placed on endpoint callback arguments #50714

mkouba merged 1 commit into from
Oct 29, 2025
+428 −1

Conversation

@michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Oct 24, 2025

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 24, 2025

/cc @brunobat (opentelemetry), @radcortez (opentelemetry)

@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link

github-actions bot commented Oct 24, 2025 •
edited
Loading

🎊 PR Preview 25cd033 has been successfully built and deployed to https://quarkus-pr-main-50714-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@michalvavrik
Copy link
Member Author

michalvavrik commented Oct 24, 2025

Strange thing, I have run all the WS Next tests and they were green (multiple times). When I saw failures in this PR CI, I rebased on the current main and all the tests I added started failing. Something has changed in the main branch, I'll investigate and fix it.

@michalvavrik
Copy link
Member Author

michalvavrik commented Oct 24, 2025

Ah, new OTel semantic #50501.

@michalvavrik michalvavrik force-pushed the feature/ws-next-span-attr-support branch 2 times, most recently from e85c392 to c758787 Compare October 24, 2025 21:51
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@brunobat
Copy link
Contributor

brunobat commented Oct 25, 2025

Yeah... sorry for the inconvenience...

@michalvavrik
Copy link
Member Author

michalvavrik commented Oct 25, 2025

Yeah... sorry for the inconvenience...

No problem :-) I was just surprised.

brunobat
brunobat approved these changes Oct 27, 2025
View reviewed changes
Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@michalvavrik michalvavrik force-pushed the feature/ws-next-span-attr-support branch from c758787 to 37e194e Compare October 29, 2025 13:54
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 29, 2025
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 29, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 37e194e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

You can consult the Develocity build scans.

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 29, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 37e194e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@mkouba mkouba merged commit 99296fe into quarkusio:main Oct 29, 2025
30 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.30 - main milestone Oct 29, 2025
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Oct 29, 2025
@michalvavrik michalvavrik deleted the feature/ws-next-span-attr-support branch October 29, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkouba mkouba mkouba approved these changes

@brunobat brunobat brunobat approved these changes

+1 more reviewer

@melloware melloware melloware approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/tracing area/websockets kind/enhancement New feature or request

Projects

None yet

Milestone

3.30.0.CR1

Development

Successfully merging this pull request may close these issues.

Can't use @SpanAttribute annotation with Websockets.NEXT @OnTextMessage

4 participants

@michalvavrik @brunobat @mkouba @melloware