Clarify process for custom domains on GitHub Pages #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-1588.quarto.org |
mcanouil
reviewed
Mar 18, 2025
topepo
reviewed
Mar 18, 2025
|
|
||
| For the first step, the [GitHub Pages documentation](https://docs.github.com/en/pages/configuring-a-custom-domain-for-your-github-pages-site/managing-a-custom-domain-for-your-github-pages-site) describes adding your domain to your repository in the **Settings** pane. | ||
| However, this creates a `CNAME` file in the location of your rendered site, | ||
| which will be overwritten whenever you render your site. |
There was a problem hiding this comment.
I thought that it was helpful to explain that the file might be overwritten. Maybe leave that in?
Co-authored-by: Mickaël Canouil <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Mar 21, 2025
* Clarify * Apply suggestions from code review Co-authored-by: Mickaël Canouil <[email protected]> * Callout values to pay attention to --------- Co-authored-by: Mickaël Canouil <[email protected]> (cherry picked from commit 5b40928)
|
Successfully created backport PR for |
|
🚀 Deployed on https://deploy-preview-1588.quarto.org |
cwickham
added a commit
that referenced
this pull request
Mar 21, 2025
* Clarify * Apply suggestions from code review Co-authored-by: Mickaël Canouil <[email protected]> * Callout values to pay attention to --------- Co-authored-by: Mickaël Canouil <[email protected]> (cherry picked from commit 5b40928) Co-authored-by: Charlotte Wickham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Custom Domain section: Preview