Fix false if condition to allow sending ICMP packet for fragmentation when datagram is too large

[derrandz]

Closes #38

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[derrandz]

@marten-seemann can we merge?

[marten-seemann]

Yes. I didn't see that you committed the fix, since you didn't re-request a review. Thanks for the fix!

[marten-seemann]

@derrandz Could you please (force-) push again? For some reason CI didn't pick up the jobs, and I don't know how to poke it manually.

[marten-seemann]

Please force-push again, without any go.mod changes.

[marten-seemann]

The changes seem gone as well.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.98%. Comparing base (321f13c) to head (5dfec41).

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   87.96%   87.98%   +0.01%     
==========================================
  Files           8        8              
  Lines         673      674       +1     
==========================================
+ Hits          592      593       +1     
  Misses         62       62              
  Partials       19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[derrandz]

Do we need to re-approve to trigger CI?

[marten-seemann]

Your fix is gone:

[derrandz]

What a weird thing happening... I guess github is tripping, I am trying to force push after rewriting history but it says it's up to date, and the commits showing on this PR aren't what I have locally...

[derrandz]

Okay good to go, I had to play some git gymnastics but we are good now.

[marten-seemann]

Please just the code change...

[derrandz]

@marten-seemann Can this go? why is the CI failing?

[marten-seemann]

Your code is wrong, that's why CI is failing. Please fix it, then we can merge.

[derrandz]

Indeed, missed one pointer sign *

[derrandz]

@marten-seemann the CI is still failing for integration tests. Why is this?

[marten-seemann]

@derrandz That's a good question. Seems to happen on master as well, I'm investigating.