http3: client support for graceful shutdown #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of quic-go v0.52.0, HTTP/3 graceful shutdown is now fully implemented for both the client and the server.
There was a problem hiding this comment.
Pull Request Overview
Adds documentation updates for HTTP/3 server graceful shutdown to reflect new behavior in quic-go v0.52.0.
- Clarifies that
Shutdownstops accepting both new connections and requests, rejects late requests withH3_REQUEST_REJECTED, and lets existing requests finish. - Removes outdated callouts about client behavior and connection-closing warnings.
- Updates description of
Shutdownreturn conditions when the context is canceled.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the HTTP/3 server documentation to reflect newly implemented graceful shutdown behavior in quic-go v0.52.0.
- Clarifies how to invoke and what to expect from
Shutdownonhttp3.Server. - Details GOAWAY frame handling and request rejection semantics.
- Updates return conditions for
Shutdown.
marten-seemann
force-pushed
the
update-graceful-shutdown
branch
from
efe2996 to
30cd171
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of quic-go v0.52.0, HTTP/3 graceful shutdown is now fully implemented for both the client and the server.