Output logs in JSON with QW_LOG_FORMAT=json
#5672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdettai
reviewed
Feb 10, 2025
quickwit/quickwit-cli/src/logger.rs
Outdated
|
|
||
| enum EventFormat<'a> { | ||
| Full(Format<Full, UtcTime<Vec<BorrowedFormatItem<'a>>>>), | ||
| Json(tracing_subscriber::fmt::format::Format<tracing_subscriber::fmt::format::Json>), |
There was a problem hiding this comment.
Suggested change
| Json(tracing_subscriber::fmt::format::Format<tracing_subscriber::fmt::format::Json>), | |
| Json(Format<tracing_subscriber::fmt::format::Json>), |
Comment on lines
123
to
126
| enum EventFormat<'a> { | ||
| Full(Format<Full, UtcTime<Vec<BorrowedFormatItem<'a>>>>), | ||
| Json(tracing_subscriber::fmt::format::Format<tracing_subscriber::fmt::format::Json>), | ||
| } |
There was a problem hiding this comment.
Is there any strong reason for using a custom event format rather than a boxed layer? Maybe from a performance point of view enum is a tiny bit better, but boxing would be substantially simpler.
quickwit/quickwit/quickwit-lambda/src/logger.rs
Lines 92 to 102 in f946626
There was a problem hiding this comment.
I assumed we didn't go for a boxed implementation in the first place for a good reason, so I also added unboxed code. I'm open to a refactor that uses the same code in cli and lambda and potentially uses boxed layers.
| tracing_subscriber::fmt::layer() | ||
| .event_format(event_format) | ||
| .fmt_fields(fmt_fields) | ||
| .with_ansi(ansi_colors), |
There was a problem hiding this comment.
what does it mean to set ansi to true if the format is json?
guilload
force-pushed
the
guilload/json-log-format
branch
from
f946626 to
9d19d56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per title.
How was this PR tested?
Ran locally and inspected logs manually