Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix index update endpoint panic when index_uri is the bucket root #5711

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rdettai
Copy link
Collaborator

@rdettai rdettai commented Mar 11, 2025

Description

Users can set the the index_uri to be the root of a bucket, and this panics when calling the index update endpoint. This PR:

  • replaces the panic with an Internal Server error
  • makes it possible to update an index even if the index_uri is the root of a bucket

How was this PR tested?

Describe how you tested this PR.

@rdettai rdettai self-assigned this Mar 11, 2025
@rdettai rdettai requested a review from guilload March 11, 2025 10:19
@rdettai rdettai force-pushed the fix-bucket-root-index-update branch from a3117da to 9a96456 Compare March 11, 2025 10:31
@rdettai rdettai force-pushed the fix-bucket-root-index-update branch from 6b51f6b to 18ab970 Compare March 11, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant