add access benchmark for columnar (#2432) #3447
PSeitzAnnotations
1 error and 4 warnings
|
coverage
Process completed with exit code 1.
|
|
useless use of `format!`:
src/indexer/mod.rs#L294
warning: useless use of `format!`
--> src/indexer/mod.rs:294:14
|
294 | (format!("{field_name_out_internal}"), Type::Str),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `field_name_out_internal.to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `#[warn(clippy::useless_format)]` on by default
|
|
redundant closure:
src/indexer/index_writer.rs#L2357
warning: redundant closure
--> src/indexer/index_writer.rs:2357:41
|
2357 | let ops: Vec<_> = (0..1000).map(|id| IndexingOp::add(id)).collect();
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `IndexingOp::add`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/indexer/index_writer.rs#L1690
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/indexer/index_writer.rs:1690:41
|
1690 | existing_ids.remove(&id);
| ^^^ help: change this to: `id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/indexer/index_writer.rs#L1686
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/indexer/index_writer.rs:1686:41
|
1686 | existing_ids.remove(&id);
| ^^^ help: change this to: `id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|