feat: image and screenshot input support - #28
Merged
Conversation
gemma3:4b is a multimodal model that supports both text and vision, enabling upcoming image input support. It offers the best balance of quality, speed, and RAM usage across all modern Macs (~3GB disk, ~6GB RAM during inference). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
…upport Introduces the `images` module with image lifecycle management: - save_image: compresses to JPEG (max 1920px, quality 85) via the `image` crate, writes to <app_data>/images/<conversation_id>/ - remove_image: deletes individual files with empty-dir cleanup - cleanup_orphaned_images: removes dirs not referenced by saved conversations (runs on startup and periodically) - encode_images_as_base64: reads files for Ollama API inclusion Extends ChatMessage with optional `images` field for multimodal requests to Ollama's /api/chat endpoint. Updates CSP to allow asset:// protocol for frontend thumbnail rendering. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
Introduces image attachment support across the frontend: - ImageThumbnails: reusable thumbnail row with preview/remove buttons and Framer Motion entrance/exit animations - ImagePreviewModal: full-screen image preview with backdrop blur, Escape key, and click-outside close - AskBarView: clipboard paste and drag-and-drop handlers with max 3 image limit, drag-over visual indicator, thumbnail row between quoted text and textarea - ChatBubble: renders image thumbnails in user message bubbles - useOllama: Message type gains imagePaths, ask() forwards image paths to the Rust backend for multimodal Ollama requests - App: orchestrates attachedImages state, stages images via Tauri IPC, wires preview modal Also fixes pre-existing ESLint warning for setPendingNewConversation in effect by replacing with ref-based change detection. 62 new tests covering all image input, preview, thumbnail, paste, drop, and integration scenarios — 100% coverage maintained. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
Adopts the industry-standard pattern (Signal, iMessage, Slack) where images are independent entities stored in a flat directory with UUID filenames, linked to messages through path references. - save_image no longer requires a conversation_id parameter - Images write directly to <app_data>/images/<uuid>.jpg - cleanup_orphaned_images compares file paths instead of directory names - Removes remove_conversation_images (no per-conversation dirs to delete) - Removes imageSessionIdRef from App.tsx (no session ID needed) This eliminates the UUID mismatch bug where images were stored under a frontend session ID but conversations were saved with a different backend-generated ID, causing cleanup to delete saved images. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
Completes the image feature integration layer: - Schema: adds image_paths TEXT column to messages table with migration for existing databases. Stores JSON-encoded arrays of file paths. - Persistence: insert_message, insert_messages_batch, and load_messages handle the new column. toPayload/fromPersisted map between frontend Message.imagePaths and the DB JSON format. - Conversation delete: loads image paths before cascade-deleting DB records, then removes each file from disk immediately. - Startup cleanup: run_image_cleanup() queries all referenced paths, diffs against files in the images/ directory, deletes orphans. - Periodic cleanup: Tokio background task repeats the sweep hourly. - get_all_image_paths() provides a single-query path collector for the cleanup sweep. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
Thumbnails showed broken icons because the webview couldn't load files via the asset:// protocol. The fix requires three config changes: - tauri.conf.json: add assetProtocol.enable with $APPDATA/images/** scope so convertFileSrc() URLs resolve to actual files - Cargo.toml: add protocol-asset feature to the tauri dependency - capabilities: remove invalid core:asset:default (doesn't exist in Tauri v2 — asset protocol is configured via tauri.conf.json) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
Moves the SQLite database from ~/.thuki/thuki.db to the standard macOS application data location at ~/Library/Application Support/ com.quietnode.thuki/thuki.db, consolidating all app data (database + images) in one directory. This follows macOS conventions — GUI desktop apps use Application Support, not dotfile directories (which are a CLI convention). Includes a one-time migration that automatically moves an existing ~/.thuki/thuki.db (plus WAL/SHM journal files) to the new location on first run so existing users don't lose conversations. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
Refactor image attachment flow for instant UI feedback and zero main-thread blocking. Previously, pasting a full-screen Retina screenshot froze the app for 2-5 seconds (macOS beachball) because image processing ran on the main thread. Key changes: - Blob URLs via URL.createObjectURL() render thumbnails instantly with a loading spinner while backend processing happens in the background - AttachedImage type replaces raw string paths, tracking id/blobUrl/filePath - ImageThumbnails component accepts ThumbnailItem[] with loading state - ImagePreviewModal accepts imageUrl (blob or asset URL) instead of file path - save_image_command is now async with spawn_blocking, moving PNG decode + Lanczos3 resize + JPEG encode off the main thread entirely - FileReader + IPC deferred via requestAnimationFrame for immediate render - AskBarView forwards File[] to parent instead of reading bytes internally - 30MB file size cap (MAX_IMAGE_SIZE_BYTES) for paste and drop - Fix env var test race condition in commands.rs with static Mutex - Add coverage(off) to migrate_legacy_db and restructure run_migrations SQL - URL.createObjectURL/revokeObjectURL mocks added to test setup Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
When submitting while images are still being processed by the backend, the UI now transitions to conversation mode immediately instead of staying in the ask bar with a spinner. - User message appears in chat bubble instantly with blob URL thumbnails - Typing indicator (dots) shows while waiting for images to finish - Once all images resolve, ask() fires and streaming begins seamlessly - ChatBubble detects blob: URLs and renders them directly (skips convertFileSrc) - AskBarView hides attached images during pending state (shown in chat instead) - isChatMode includes isSubmitPending for immediate morphing transition - Cancelled pending submit (all images fail) reverts to normal ask bar Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
- Chat bubble thumbnails show loading spinner for blob URL images
(backend still processing) via startsWith('blob:') detection
- Stop button shows red stop style during pending submit (not orange spinner)
- Cancel during pending submit reverts to pre-submit state (undo-send):
restores query text, quoted context, keeps images, re-focuses textarea
- Cancel during active generation still calls cancel_generation as before
- Unified handleCancel routes to undo-send or generation cancel based on state
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
Use filePath for already-processed images and blob URL only for images still being processed. Previously all images showed loading spinners in the pending user message chat bubble regardless of processing state. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
Reset previewImageUrl in requestHideOverlay so the enlarged image modal doesn't persist across overlay activations. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
…iew, and doc accuracy - Add path containment check to `remove_image` preventing arbitrary file deletion via IPC (path-traversal mitigation) - Restore user query and context when all images fail during deferred submit (previously lost permanently) - Handle blob: URLs in `handleChatImagePreview` without wrapping in `convertFileSrc` (fixes garbage asset:// URLs during pending submit) - Hide CopyButton on image-only messages with empty content - Replace `unwrap_or_default()` with `expect()` in history.rs JSON serialization (prevents silent data corruption) - Add `coverage(off)` annotations to cleanup orchestration functions in lib.rs - Fix stale doc comments in commands.rs and images.rs Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
- Replace per-call-site map_err closures with fn err<E: Display> helper in images.rs, eliminating phantom LLVM functions that prevented 100% function coverage (closures counted individually by llvm-cov) - Strip base64 image data from in-memory ConversationHistory after each turn so subsequent requests don't re-send stale image payloads - Remove coverage(off) from get_all_image_paths (it has real SQL logic) - Revoke blob URLs when overlay hides to prevent memory leaks - Fix blob: URL preview in chat history (skip convertFileSrc for blobs) - Restore --fail-under-lines 100 in test:backend:coverage command - Add tests covering error-path branches and new code paths Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
This was referenced Apr 5, 2026
quiet-node
added a commit
that referenced
this pull request
Apr 10, 2026
* feat: switch default model from llama3.2:3b to gemma3:4b
gemma3:4b is a multimodal model that supports both text and vision,
enabling upcoming image input support. It offers the best balance of
quality, speed, and RAM usage across all modern Macs (~3GB disk, ~6GB
RAM during inference).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* feat: add backend image storage, compression, and Ollama multimodal support
Introduces the `images` module with image lifecycle management:
- save_image: compresses to JPEG (max 1920px, quality 85) via the
`image` crate, writes to <app_data>/images/<conversation_id>/
- remove_image: deletes individual files with empty-dir cleanup
- cleanup_orphaned_images: removes dirs not referenced by saved
conversations (runs on startup and periodically)
- encode_images_as_base64: reads files for Ollama API inclusion
Extends ChatMessage with optional `images` field for multimodal
requests to Ollama's /api/chat endpoint. Updates CSP to allow
asset:// protocol for frontend thumbnail rendering.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* feat: add frontend image input via clipboard paste and drag-and-drop
Introduces image attachment support across the frontend:
- ImageThumbnails: reusable thumbnail row with preview/remove buttons
and Framer Motion entrance/exit animations
- ImagePreviewModal: full-screen image preview with backdrop blur,
Escape key, and click-outside close
- AskBarView: clipboard paste and drag-and-drop handlers with max 3
image limit, drag-over visual indicator, thumbnail row between
quoted text and textarea
- ChatBubble: renders image thumbnails in user message bubbles
- useOllama: Message type gains imagePaths, ask() forwards image
paths to the Rust backend for multimodal Ollama requests
- App: orchestrates attachedImages state, stages images via Tauri
IPC, wires preview modal
Also fixes pre-existing ESLint warning for setPendingNewConversation
in effect by replacing with ref-based change detection.
62 new tests covering all image input, preview, thumbnail, paste,
drop, and integration scenarios — 100% coverage maintained.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* refactor: switch image storage from per-conversation dirs to flat layout
Adopts the industry-standard pattern (Signal, iMessage, Slack) where
images are independent entities stored in a flat directory with UUID
filenames, linked to messages through path references.
- save_image no longer requires a conversation_id parameter
- Images write directly to <app_data>/images/<uuid>.jpg
- cleanup_orphaned_images compares file paths instead of directory names
- Removes remove_conversation_images (no per-conversation dirs to delete)
- Removes imageSessionIdRef from App.tsx (no session ID needed)
This eliminates the UUID mismatch bug where images were stored under a
frontend session ID but conversations were saved with a different
backend-generated ID, causing cleanup to delete saved images.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* feat: persist image paths to SQLite with cleanup and immediate delete
Completes the image feature integration layer:
- Schema: adds image_paths TEXT column to messages table with migration
for existing databases. Stores JSON-encoded arrays of file paths.
- Persistence: insert_message, insert_messages_batch, and load_messages
handle the new column. toPayload/fromPersisted map between frontend
Message.imagePaths and the DB JSON format.
- Conversation delete: loads image paths before cascade-deleting DB
records, then removes each file from disk immediately.
- Startup cleanup: run_image_cleanup() queries all referenced paths,
diffs against files in the images/ directory, deletes orphans.
- Periodic cleanup: Tokio background task repeats the sweep hourly.
- get_all_image_paths() provides a single-query path collector for
the cleanup sweep.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* fix: enable Tauri asset protocol for image thumbnail rendering
Thumbnails showed broken icons because the webview couldn't load
files via the asset:// protocol. The fix requires three config
changes:
- tauri.conf.json: add assetProtocol.enable with $APPDATA/images/**
scope so convertFileSrc() URLs resolve to actual files
- Cargo.toml: add protocol-asset feature to the tauri dependency
- capabilities: remove invalid core:asset:default (doesn't exist
in Tauri v2 — asset protocol is configured via tauri.conf.json)
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* refactor: consolidate database into Tauri app data directory
Moves the SQLite database from ~/.thuki/thuki.db to the standard
macOS application data location at ~/Library/Application Support/
com.quietnode.thuki/thuki.db, consolidating all app data (database
+ images) in one directory.
This follows macOS conventions — GUI desktop apps use Application
Support, not dotfile directories (which are a CLI convention).
Includes a one-time migration that automatically moves an existing
~/.thuki/thuki.db (plus WAL/SHM journal files) to the new location
on first run so existing users don't lose conversations.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* feat: non-blocking image upload with blob URLs and async processing
Refactor image attachment flow for instant UI feedback and zero main-thread
blocking. Previously, pasting a full-screen Retina screenshot froze the app
for 2-5 seconds (macOS beachball) because image processing ran on the main
thread.
Key changes:
- Blob URLs via URL.createObjectURL() render thumbnails instantly with a
loading spinner while backend processing happens in the background
- AttachedImage type replaces raw string paths, tracking id/blobUrl/filePath
- ImageThumbnails component accepts ThumbnailItem[] with loading state
- ImagePreviewModal accepts imageUrl (blob or asset URL) instead of file path
- save_image_command is now async with spawn_blocking, moving PNG decode +
Lanczos3 resize + JPEG encode off the main thread entirely
- FileReader + IPC deferred via requestAnimationFrame for immediate render
- AskBarView forwards File[] to parent instead of reading bytes internally
- 30MB file size cap (MAX_IMAGE_SIZE_BYTES) for paste and drop
- Fix env var test race condition in commands.rs with static Mutex
- Add coverage(off) to migrate_legacy_db and restructure run_migrations SQL
- URL.createObjectURL/revokeObjectURL mocks added to test setup
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* feat: deferred submit with instant chat transition for pending images
When submitting while images are still being processed by the backend,
the UI now transitions to conversation mode immediately instead of
staying in the ask bar with a spinner.
- User message appears in chat bubble instantly with blob URL thumbnails
- Typing indicator (dots) shows while waiting for images to finish
- Once all images resolve, ask() fires and streaming begins seamlessly
- ChatBubble detects blob: URLs and renders them directly (skips convertFileSrc)
- AskBarView hides attached images during pending state (shown in chat instead)
- isChatMode includes isSubmitPending for immediate morphing transition
- Cancelled pending submit (all images fail) reverts to normal ask bar
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* feat: undo-send cancel, loading thumbnails in chat, and stop button UX
- Chat bubble thumbnails show loading spinner for blob URL images
(backend still processing) via startsWith('blob:') detection
- Stop button shows red stop style during pending submit (not orange spinner)
- Cancel during pending submit reverts to pre-submit state (undo-send):
restores query text, quoted context, keeps images, re-focuses textarea
- Cancel during active generation still calls cancel_generation as before
- Unified handleCancel routes to undo-send or generation cancel based on state
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* fix: show loading spinner only for unprocessed images in pending submit
Use filePath for already-processed images and blob URL only for images
still being processed. Previously all images showed loading spinners
in the pending user message chat bubble regardless of processing state.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* fix: clear image preview modal when overlay hides
Reset previewImageUrl in requestHideOverlay so the enlarged image
modal doesn't persist across overlay activations.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* fix: code review fixes — path traversal, query restore, blob URL preview, and doc accuracy
- Add path containment check to `remove_image` preventing arbitrary file
deletion via IPC (path-traversal mitigation)
- Restore user query and context when all images fail during deferred
submit (previously lost permanently)
- Handle blob: URLs in `handleChatImagePreview` without wrapping in
`convertFileSrc` (fixes garbage asset:// URLs during pending submit)
- Hide CopyButton on image-only messages with empty content
- Replace `unwrap_or_default()` with `expect()` in history.rs JSON
serialization (prevents silent data corruption)
- Add `coverage(off)` annotations to cleanup orchestration functions
in lib.rs
- Fix stale doc comments in commands.rs and images.rs
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* fix: achieve 100% backend coverage and patch code review issues
- Replace per-call-site map_err closures with fn err<E: Display> helper
in images.rs, eliminating phantom LLVM functions that prevented 100%
function coverage (closures counted individually by llvm-cov)
- Strip base64 image data from in-memory ConversationHistory after each
turn so subsequent requests don't re-send stale image payloads
- Remove coverage(off) from get_all_image_paths (it has real SQL logic)
- Revoke blob URLs when overlay hides to prevent memory leaks
- Fix blob: URL preview in chat history (skip convertFileSrc for blobs)
- Restore --fail-under-lines 100 in test:backend:coverage command
- Add tests covering error-path branches and new code paths
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
---------
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
quiet-node
added a commit
that referenced
this pull request
Apr 10, 2026
* feat: switch default model from llama3.2:3b to gemma3:4b
gemma3:4b is a multimodal model that supports both text and vision,
enabling upcoming image input support. It offers the best balance of
quality, speed, and RAM usage across all modern Macs (~3GB disk, ~6GB
RAM during inference).
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* feat: add backend image storage, compression, and Ollama multimodal support
Introduces the `images` module with image lifecycle management:
- save_image: compresses to JPEG (max 1920px, quality 85) via the
`image` crate, writes to <app_data>/images/<conversation_id>/
- remove_image: deletes individual files with empty-dir cleanup
- cleanup_orphaned_images: removes dirs not referenced by saved
conversations (runs on startup and periodically)
- encode_images_as_base64: reads files for Ollama API inclusion
Extends ChatMessage with optional `images` field for multimodal
requests to Ollama's /api/chat endpoint. Updates CSP to allow
asset:// protocol for frontend thumbnail rendering.
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* feat: add frontend image input via clipboard paste and drag-and-drop
Introduces image attachment support across the frontend:
- ImageThumbnails: reusable thumbnail row with preview/remove buttons
and Framer Motion entrance/exit animations
- ImagePreviewModal: full-screen image preview with backdrop blur,
Escape key, and click-outside close
- AskBarView: clipboard paste and drag-and-drop handlers with max 3
image limit, drag-over visual indicator, thumbnail row between
quoted text and textarea
- ChatBubble: renders image thumbnails in user message bubbles
- useOllama: Message type gains imagePaths, ask() forwards image
paths to the Rust backend for multimodal Ollama requests
- App: orchestrates attachedImages state, stages images via Tauri
IPC, wires preview modal
Also fixes pre-existing ESLint warning for setPendingNewConversation
in effect by replacing with ref-based change detection.
62 new tests covering all image input, preview, thumbnail, paste,
drop, and integration scenarios — 100% coverage maintained.
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* refactor: switch image storage from per-conversation dirs to flat layout
Adopts the industry-standard pattern (Signal, iMessage, Slack) where
images are independent entities stored in a flat directory with UUID
filenames, linked to messages through path references.
- save_image no longer requires a conversation_id parameter
- Images write directly to <app_data>/images/<uuid>.jpg
- cleanup_orphaned_images compares file paths instead of directory names
- Removes remove_conversation_images (no per-conversation dirs to delete)
- Removes imageSessionIdRef from App.tsx (no session ID needed)
This eliminates the UUID mismatch bug where images were stored under a
frontend session ID but conversations were saved with a different
backend-generated ID, causing cleanup to delete saved images.
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* feat: persist image paths to SQLite with cleanup and immediate delete
Completes the image feature integration layer:
- Schema: adds image_paths TEXT column to messages table with migration
for existing databases. Stores JSON-encoded arrays of file paths.
- Persistence: insert_message, insert_messages_batch, and load_messages
handle the new column. toPayload/fromPersisted map between frontend
Message.imagePaths and the DB JSON format.
- Conversation delete: loads image paths before cascade-deleting DB
records, then removes each file from disk immediately.
- Startup cleanup: run_image_cleanup() queries all referenced paths,
diffs against files in the images/ directory, deletes orphans.
- Periodic cleanup: Tokio background task repeats the sweep hourly.
- get_all_image_paths() provides a single-query path collector for
the cleanup sweep.
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* fix: enable Tauri asset protocol for image thumbnail rendering
Thumbnails showed broken icons because the webview couldn't load
files via the asset:// protocol. The fix requires three config
changes:
- tauri.conf.json: add assetProtocol.enable with $APPDATA/images/**
scope so convertFileSrc() URLs resolve to actual files
- Cargo.toml: add protocol-asset feature to the tauri dependency
- capabilities: remove invalid core:asset:default (doesn't exist
in Tauri v2 — asset protocol is configured via tauri.conf.json)
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* refactor: consolidate database into Tauri app data directory
Moves the SQLite database from ~/.thuki/thuki.db to the standard
macOS application data location at ~/Library/Application Support/
com.quietnode.thuki/thuki.db, consolidating all app data (database
+ images) in one directory.
This follows macOS conventions — GUI desktop apps use Application
Support, not dotfile directories (which are a CLI convention).
Includes a one-time migration that automatically moves an existing
~/.thuki/thuki.db (plus WAL/SHM journal files) to the new location
on first run so existing users don't lose conversations.
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* feat: non-blocking image upload with blob URLs and async processing
Refactor image attachment flow for instant UI feedback and zero main-thread
blocking. Previously, pasting a full-screen Retina screenshot froze the app
for 2-5 seconds (macOS beachball) because image processing ran on the main
thread.
Key changes:
- Blob URLs via URL.createObjectURL() render thumbnails instantly with a
loading spinner while backend processing happens in the background
- AttachedImage type replaces raw string paths, tracking id/blobUrl/filePath
- ImageThumbnails component accepts ThumbnailItem[] with loading state
- ImagePreviewModal accepts imageUrl (blob or asset URL) instead of file path
- save_image_command is now async with spawn_blocking, moving PNG decode +
Lanczos3 resize + JPEG encode off the main thread entirely
- FileReader + IPC deferred via requestAnimationFrame for immediate render
- AskBarView forwards File[] to parent instead of reading bytes internally
- 30MB file size cap (MAX_IMAGE_SIZE_BYTES) for paste and drop
- Fix env var test race condition in commands.rs with static Mutex
- Add coverage(off) to migrate_legacy_db and restructure run_migrations SQL
- URL.createObjectURL/revokeObjectURL mocks added to test setup
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* feat: deferred submit with instant chat transition for pending images
When submitting while images are still being processed by the backend,
the UI now transitions to conversation mode immediately instead of
staying in the ask bar with a spinner.
- User message appears in chat bubble instantly with blob URL thumbnails
- Typing indicator (dots) shows while waiting for images to finish
- Once all images resolve, ask() fires and streaming begins seamlessly
- ChatBubble detects blob: URLs and renders them directly (skips convertFileSrc)
- AskBarView hides attached images during pending state (shown in chat instead)
- isChatMode includes isSubmitPending for immediate morphing transition
- Cancelled pending submit (all images fail) reverts to normal ask bar
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* feat: undo-send cancel, loading thumbnails in chat, and stop button UX
- Chat bubble thumbnails show loading spinner for blob URL images
(backend still processing) via startsWith('blob:') detection
- Stop button shows red stop style during pending submit (not orange spinner)
- Cancel during pending submit reverts to pre-submit state (undo-send):
restores query text, quoted context, keeps images, re-focuses textarea
- Cancel during active generation still calls cancel_generation as before
- Unified handleCancel routes to undo-send or generation cancel based on state
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* fix: show loading spinner only for unprocessed images in pending submit
Use filePath for already-processed images and blob URL only for images
still being processed. Previously all images showed loading spinners
in the pending user message chat bubble regardless of processing state.
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* fix: clear image preview modal when overlay hides
Reset previewImageUrl in requestHideOverlay so the enlarged image
modal doesn't persist across overlay activations.
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* fix: code review fixes — path traversal, query restore, blob URL preview, and doc accuracy
- Add path containment check to `remove_image` preventing arbitrary file
deletion via IPC (path-traversal mitigation)
- Restore user query and context when all images fail during deferred
submit (previously lost permanently)
- Handle blob: URLs in `handleChatImagePreview` without wrapping in
`convertFileSrc` (fixes garbage asset:// URLs during pending submit)
- Hide CopyButton on image-only messages with empty content
- Replace `unwrap_or_default()` with `expect()` in history.rs JSON
serialization (prevents silent data corruption)
- Add `coverage(off)` annotations to cleanup orchestration functions
in lib.rs
- Fix stale doc comments in commands.rs and images.rs
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* fix: achieve 100% backend coverage and patch code review issues
- Replace per-call-site map_err closures with fn err<E: Display> helper
in images.rs, eliminating phantom LLVM functions that prevented 100%
function coverage (closures counted individually by llvm-cov)
- Strip base64 image data from in-memory ConversationHistory after each
turn so subsequent requests don't re-send stale image payloads
- Remove coverage(off) from get_all_image_paths (it has real SQL logic)
- Revoke blob URLs when overlay hides to prevent memory leaks
- Fix blob: URL preview in chat history (skip convertFileSrc for blobs)
- Restore --fail-under-lines 100 in test:backend:coverage command
- Add tests covering error-path branches and new code paths
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
---------
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
quiet-node
added a commit
that referenced
this pull request
Apr 11, 2026
* feat: switch default model from llama3.2:3b to gemma3:4b
gemma3:4b is a multimodal model that supports both text and vision,
enabling upcoming image input support. It offers the best balance of
quality, speed, and RAM usage across all modern Macs (~3GB disk, ~6GB
RAM during inference).
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* feat: add backend image storage, compression, and Ollama multimodal support
Introduces the `images` module with image lifecycle management:
- save_image: compresses to JPEG (max 1920px, quality 85) via the
`image` crate, writes to <app_data>/images/<conversation_id>/
- remove_image: deletes individual files with empty-dir cleanup
- cleanup_orphaned_images: removes dirs not referenced by saved
conversations (runs on startup and periodically)
- encode_images_as_base64: reads files for Ollama API inclusion
Extends ChatMessage with optional `images` field for multimodal
requests to Ollama's /api/chat endpoint. Updates CSP to allow
asset:// protocol for frontend thumbnail rendering.
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* feat: add frontend image input via clipboard paste and drag-and-drop
Introduces image attachment support across the frontend:
- ImageThumbnails: reusable thumbnail row with preview/remove buttons
and Framer Motion entrance/exit animations
- ImagePreviewModal: full-screen image preview with backdrop blur,
Escape key, and click-outside close
- AskBarView: clipboard paste and drag-and-drop handlers with max 3
image limit, drag-over visual indicator, thumbnail row between
quoted text and textarea
- ChatBubble: renders image thumbnails in user message bubbles
- useOllama: Message type gains imagePaths, ask() forwards image
paths to the Rust backend for multimodal Ollama requests
- App: orchestrates attachedImages state, stages images via Tauri
IPC, wires preview modal
Also fixes pre-existing ESLint warning for setPendingNewConversation
in effect by replacing with ref-based change detection.
62 new tests covering all image input, preview, thumbnail, paste,
drop, and integration scenarios — 100% coverage maintained.
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* refactor: switch image storage from per-conversation dirs to flat layout
Adopts the industry-standard pattern (Signal, iMessage, Slack) where
images are independent entities stored in a flat directory with UUID
filenames, linked to messages through path references.
- save_image no longer requires a conversation_id parameter
- Images write directly to <app_data>/images/<uuid>.jpg
- cleanup_orphaned_images compares file paths instead of directory names
- Removes remove_conversation_images (no per-conversation dirs to delete)
- Removes imageSessionIdRef from App.tsx (no session ID needed)
This eliminates the UUID mismatch bug where images were stored under a
frontend session ID but conversations were saved with a different
backend-generated ID, causing cleanup to delete saved images.
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* feat: persist image paths to SQLite with cleanup and immediate delete
Completes the image feature integration layer:
- Schema: adds image_paths TEXT column to messages table with migration
for existing databases. Stores JSON-encoded arrays of file paths.
- Persistence: insert_message, insert_messages_batch, and load_messages
handle the new column. toPayload/fromPersisted map between frontend
Message.imagePaths and the DB JSON format.
- Conversation delete: loads image paths before cascade-deleting DB
records, then removes each file from disk immediately.
- Startup cleanup: run_image_cleanup() queries all referenced paths,
diffs against files in the images/ directory, deletes orphans.
- Periodic cleanup: Tokio background task repeats the sweep hourly.
- get_all_image_paths() provides a single-query path collector for
the cleanup sweep.
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* fix: enable Tauri asset protocol for image thumbnail rendering
Thumbnails showed broken icons because the webview couldn't load
files via the asset:// protocol. The fix requires three config
changes:
- tauri.conf.json: add assetProtocol.enable with $APPDATA/images/**
scope so convertFileSrc() URLs resolve to actual files
- Cargo.toml: add protocol-asset feature to the tauri dependency
- capabilities: remove invalid core:asset:default (doesn't exist
in Tauri v2 — asset protocol is configured via tauri.conf.json)
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* refactor: consolidate database into Tauri app data directory
Moves the SQLite database from ~/.thuki/thuki.db to the standard
macOS application data location at ~/Library/Application Support/
com.quietnode.thuki/thuki.db, consolidating all app data (database
+ images) in one directory.
This follows macOS conventions — GUI desktop apps use Application
Support, not dotfile directories (which are a CLI convention).
Includes a one-time migration that automatically moves an existing
~/.thuki/thuki.db (plus WAL/SHM journal files) to the new location
on first run so existing users don't lose conversations.
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* feat: non-blocking image upload with blob URLs and async processing
Refactor image attachment flow for instant UI feedback and zero main-thread
blocking. Previously, pasting a full-screen Retina screenshot froze the app
for 2-5 seconds (macOS beachball) because image processing ran on the main
thread.
Key changes:
- Blob URLs via URL.createObjectURL() render thumbnails instantly with a
loading spinner while backend processing happens in the background
- AttachedImage type replaces raw string paths, tracking id/blobUrl/filePath
- ImageThumbnails component accepts ThumbnailItem[] with loading state
- ImagePreviewModal accepts imageUrl (blob or asset URL) instead of file path
- save_image_command is now async with spawn_blocking, moving PNG decode +
Lanczos3 resize + JPEG encode off the main thread entirely
- FileReader + IPC deferred via requestAnimationFrame for immediate render
- AskBarView forwards File[] to parent instead of reading bytes internally
- 30MB file size cap (MAX_IMAGE_SIZE_BYTES) for paste and drop
- Fix env var test race condition in commands.rs with static Mutex
- Add coverage(off) to migrate_legacy_db and restructure run_migrations SQL
- URL.createObjectURL/revokeObjectURL mocks added to test setup
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* feat: deferred submit with instant chat transition for pending images
When submitting while images are still being processed by the backend,
the UI now transitions to conversation mode immediately instead of
staying in the ask bar with a spinner.
- User message appears in chat bubble instantly with blob URL thumbnails
- Typing indicator (dots) shows while waiting for images to finish
- Once all images resolve, ask() fires and streaming begins seamlessly
- ChatBubble detects blob: URLs and renders them directly (skips convertFileSrc)
- AskBarView hides attached images during pending state (shown in chat instead)
- isChatMode includes isSubmitPending for immediate morphing transition
- Cancelled pending submit (all images fail) reverts to normal ask bar
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* feat: undo-send cancel, loading thumbnails in chat, and stop button UX
- Chat bubble thumbnails show loading spinner for blob URL images
(backend still processing) via startsWith('blob:') detection
- Stop button shows red stop style during pending submit (not orange spinner)
- Cancel during pending submit reverts to pre-submit state (undo-send):
restores query text, quoted context, keeps images, re-focuses textarea
- Cancel during active generation still calls cancel_generation as before
- Unified handleCancel routes to undo-send or generation cancel based on state
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* fix: show loading spinner only for unprocessed images in pending submit
Use filePath for already-processed images and blob URL only for images
still being processed. Previously all images showed loading spinners
in the pending user message chat bubble regardless of processing state.
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* fix: clear image preview modal when overlay hides
Reset previewImageUrl in requestHideOverlay so the enlarged image
modal doesn't persist across overlay activations.
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* fix: code review fixes — path traversal, query restore, blob URL preview, and doc accuracy
- Add path containment check to `remove_image` preventing arbitrary file
deletion via IPC (path-traversal mitigation)
- Restore user query and context when all images fail during deferred
submit (previously lost permanently)
- Handle blob: URLs in `handleChatImagePreview` without wrapping in
`convertFileSrc` (fixes garbage asset:// URLs during pending submit)
- Hide CopyButton on image-only messages with empty content
- Replace `unwrap_or_default()` with `expect()` in history.rs JSON
serialization (prevents silent data corruption)
- Add `coverage(off)` annotations to cleanup orchestration functions
in lib.rs
- Fix stale doc comments in commands.rs and images.rs
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
* fix: achieve 100% backend coverage and patch code review issues
- Replace per-call-site map_err closures with fn err<E: Display> helper
in images.rs, eliminating phantom LLVM functions that prevented 100%
function coverage (closures counted individually by llvm-cov)
- Strip base64 image data from in-memory ConversationHistory after each
turn so subsequent requests don't re-send stale image payloads
- Remove coverage(off) from get_all_image_paths (it has real SQL logic)
- Revoke blob URLs when overlay hides to prevent memory leaks
- Fix blob: URL preview in chat history (skip convertFileSrc for blobs)
- Restore --fail-under-lines 100 in test:backend:coverage command
- Add tests covering error-path branches and new code paths
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
---------
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
This was referenced Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spawn_blocking; users can type and submit while thumbnails loadremove_imagevalidates paths withcanonicalize()+starts_with(images_root)before deletionTest plan
bun run test:all— all tests pass, 100% coveragebun run validate-build— zero warnings, zero errors🤖 Generated with Claude Code