Forward Declare Aliases to Prevent Style Warnings #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stylewarning
approved these changes
Jun 3, 2022
stylewarning
requested changes
Jun 3, 2022
| (tref matrix i j)))) | ||
| target)))) | ||
| ;;; Synonym for upper-triangular | ||
| (declaim (ftype (function (matrix)) triu)) |
There was a problem hiding this comment.
these aren't necessarily matrix functions, just the implementation provided is
There was a problem hiding this comment.
If these were to be replaced with t, would that impair any optimizations?
There was a problem hiding this comment.
I don't think so. There's a lot of indirection already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #165 by declaiming the aliases as functions so that the compiler doesn't emit a style warning.