Adapt to OrderedDict repr change in Python 3.12 - #621
Closed
musicinmybrain wants to merge 1 commit into
Closed
Conversation
Owner
|
Working on it. The patch will be modified slightly for backwards
compatibility with prior releases. Should have a bugfix released in a day
or two.
P.S. dnf5 looks amazing!
…On Tue, Jul 11, 2023 at 2:33 PM Ben Beasley ***@***.***> wrote:
python/cpython#101661 <python/cpython#101661>
Fixes, on Python 3.12.0b3:
E AssertionError: "UUID[304 chars] ('ExifTag', OrderedDict({'Make': 'HTC'}))])" != "UUID[304 chars] ('ExifTag', OrderedDict([('Make', 'HTC')]))])"
E UUID Box (uuid) @ (1135519, 142)
E UUID: 4a706754-6966-6645-7869-662d3e4a5032 (EXIF)
E UUID Data: OrderedDict([ ('ImageWidth', 256),
E ('ImageLength', 512),
E ( 'TileOffsets',
E array([ 0, 10, 20, ..., 70, 80, 90], dtype=uint32)),
E - ('ExifTag', OrderedDict({'Make': 'HTC'}))])
E ? ^ ^ ^
E + ('ExifTag', OrderedDict([('Make', 'HTC')]))])
E ? ^^ ^ ^^
tests/test_printing.py:1071: AssertionError
=========================== short test summary info ============================
FAILED tests/test_printing.py::TestPrinting::test_exif_uuid - AssertionError:...
================== 1 failed, 605 passed, 1 skipped in 51.41s ===================
Downstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=2220255
------------------------------
You can view, comment on, or merge this pull request online at:
#621
Commit Summary
- 5cd1c93
<5cd1c93>
Adapt to OrderedDict repr change in Python 3.12
File Changes
(1 file <https://github.com/quintusdias/glymur/pull/621/files>)
- *M* tests/test_printing.py
<https://github.com/quintusdias/glymur/pull/621/files#diff-bfdb764389cad704e719d2b5bece253a7b13faf5e12bb001f60eaf4d356f2ad3>
(6)
Patch Links:
- https://github.com/quintusdias/glymur/pull/621.patch
- https://github.com/quintusdias/glymur/pull/621.diff
—
Reply to this email directly, view it on GitHub
<#621>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVCIXRQB757HQU5XAIIAQ3XPW2ABANCNFSM6AAAAAA2GQZLLQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
John Evans
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python/cpython#101661
Fixes, on Python 3.12.0b3:
Downstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=2220255