Skip to content

Remove example app code - outdated packages present security risk. #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025

Conversation

rlundinSlack
Copy link
Contributor

Many dependabot alerts for this repo relate to outdated packages in example code. Removing these code samples will address a large number of security vulnerabilities + we are not allowing new app creation at this time anyway, so this should not impact CLI users.

@kvnlam
Copy link
Contributor

kvnlam commented Mar 27, 2025

@rlundinSlack i think the changes look good. there doesn't appear to be any dependencies on the /examples directory so i feel like this should be a safe change

should we also update the main README.md file by removing the reference to example apps?

<li><a href="https://quip.com/dev/liveapps/samples">Example Apps</a> - Browse open-source code.</li>

Copy link
Contributor

@kvnlam kvnlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rlundinSlack rlundinSlack merged commit 6f3bf61 into next Mar 27, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants