feat: add search result quality feedback loop (#604) - #1
Open
qwenbona wants to merge 1 commit into
Open
Conversation
Add --feedback flag to search_knowledge.py that prompts users after displaying results and logs feedback to data/search-feedback.jsonl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
--feedbackflag tosearch_knowledge.pythat logs search quality feedback todata/search-feedback.jsonl.Changes
--feedbackCLI flag (positive/negative) for search resultsWhy
Enables iterative improvement of search relevance by collecting structured feedback on result quality. Addresses Ikalus1988#604.
Testing
python search_knowledge.py "test query" --feedback positive→ logs to JSONL--feedback→ behavior identical to before