Skip to content

Conversation

@VEH9
Copy link
Contributor

@VEH9 VEH9 commented Oct 21, 2025

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests
  • Other

Why is it needed?

transitionend and animationend events could fire on inner animations inside the modal instead of the modal container itself.
Because these listeners were registered with { once: true }, they were removed after the first event, causing the modal closing logic to never run and leaving the modal partially open. As a result, the user could no longer interact with the page.

For example, if there is an animated placeholder on an <input> inside the modal, the transitionend event could fire on that placeholder before the modal’s own transition finishes. This would remove the listener too early and prevent the modal from closing completely.

Before:

2025-10-21.18.43.39.mov

After:

2025-10-21.18.45.22.mov

Same issue
#1004

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have add necessary docs (if needed)
  • Added new tests to cover the fix / functionality

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2025

🦋 Changeset detected

Latest commit: 244c9fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@qwik-ui/headless Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@VEH9
Copy link
Contributor Author

VEH9 commented Oct 21, 2025

I have read the CLA Document and I hereby sign the CLA

…there are animated elements inside the modal
@VEH9 VEH9 force-pushed the fix-modal-closing-bug branch from f713993 to 244c9fd Compare October 21, 2025 14:07
github-actions bot added a commit that referenced this pull request Oct 21, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 21, 2025

Open in StackBlitz

npm i https://pkg.pr.new/qwikifiers/qwik-ui@1159
npm i https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/headless@1159
npm i https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/styled@1159
npm i https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/utils@1159

commit: 244c9fd

@maiieul
Copy link
Contributor

maiieul commented Oct 24, 2025

LGTM 👍 thanks for the fix @VEH9

@maiieul maiieul merged commit a2b96c4 into qwikifiers:main Oct 24, 2025
5 checks passed
@github-actions github-actions bot mentioned this pull request Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants