Fix rare count_test edge case (#2) #622
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix rare count_test edge case * fix name typo
jimhester
reviewed
Nov 11, 2025
Member
jimhester
left a comment
jimhester
left a comment
There was a problem hiding this comment.
Had one minor style change suggestion.
Also can you please add a bullet to NEWS? It should briefly describe the change and end with (@yourname, #issuenumber).
Contributor
Author
|
@jimhester Thank you very much for the review, one question from me
Do you mean that the current bullet is not clear enough, or would you prefer that I create an issue for this (currently there is no open issue, I created this PR right after figuring out the problem)? |
Co-authored-by: Jim Hester <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
In our enterprise solution, we have discovered a peculiar edge case when
count_testfunction is called with.current_testnot yet initialized, leading to error:For us, we encountered it when calculating coverage for the
digestwhen usingtinytestUbuntu libraries (funnily enough, when installing tinytest from source, the issue did not appear). That makes reproducing the issue really tedious, although I was able to do it on macOS as well. Nevertheless, I believe that there is no harm in adding that if statement to cover that edge case, even if it's super rare, simply to make sure thecovris not vulnerable to weird/unexpected package combinations in the future.