Set message durable as default #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriele Santomaggio <[email protected]>
releaded to rabbitmq/rabbitmq-server#13918 Signed-off-by: Gabriele Santomaggio <[email protected]>
ansd
reviewed
May 20, 2025
There was a problem hiding this comment.
Thank you, the PR looks good to me.
I'm not sure whether we need the new function NewMessageWithPersistence. I personally would leave it out to keep the API minimal.
If you decide to keep this function, maybe it's worth using the same naming as in the AMQP spec, that is "durable" instead of "persistence".
releaded to rabbitmq/rabbitmq-server#13918 Signed-off-by: Gabriele Santomaggio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
durable=trueby default.durable=falsebtw