Shovel: swap queue for lqueue (backport #14890) #14891
Merged
+20
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit b905370)
the `queue' module is not aware of the queue length, which means its `len/1` function is O(n) while with `lqueue' it is O(1). We rely on `queue:len/1' for a shovel metric, so why not use a more efficient drop-in replacement our team has developed in 2011. (cherry picked from commit 7aa7433)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #14873.
The
queuemodule is not aware of the queuelength, which means its
len/1functionis O(n) [1] while with
lqueueit is O(1).We rely on
queue:len/1for a shovel metric,so why not use a more efficient drop-in replacement
our team has developed in 2011.
This is an automatic backport of pull request Shovel: swap queue for lqueue #14890 done by Mergify.