Skip to content

Conversation

@ShiCheng-Lu
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings September 4, 2025 14:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the react-native-radar package version from 3.22.1 to 3.23.0. The changes include updating version numbers across multiple platform-specific files and adding a new version management script.

  • Version bump from 3.22.1 to 3.23.0 across all platform configurations
  • Addition of automated version management script (set-version.sh)
  • iOS RadarSDK dependency specification change from flexible to exact version

Reviewed Changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/version.ts Updates exported version constant to 3.23.0
package.json Updates npm package version to 3.23.0
ios/RNRadar.mm Updates iOS platform SDK version string to 3.23.0
android/src/oldarch/java/com/radar/RadarModule.java Updates Android old architecture SDK version to 3.23.0
android/src/newarch/java/com/radar/RadarModule.kt Updates Android new architecture SDK version to 3.23.0
Radar.podspec Changes RadarSDK dependency from flexible (~> 3.23.1) to exact version (3.23.1)
set-version.sh Adds new shell script for automated version management across platforms
Files not reviewed (1)
  • example/package-lock.json: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

s.private_header_files = "ios/**/*.h"

s.dependency "RadarSDK", "~> 3.23.1"
s.dependency "RadarSDK", "3.23.1"
Copy link

Copilot AI Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RadarSDK dependency version (3.23.1) is higher than the react-native-radar package version being released (3.23.0). This creates a confusing version relationship where the wrapper has a lower version than its dependency. Consider aligning the versions or using a flexible version specification like '~> 3.23.0' to allow compatible updates.

Suggested change
s.dependency "RadarSDK", "3.23.1"
s.dependency "RadarSDK", "~> 3.23.0"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants