Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline tasks can return multiple outputs to unpack #263

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

jrs65
Copy link
Contributor

@jrs65 jrs65 commented Feb 6, 2024

  • test(pipeline): ensure multiple output pipeline tasks are supported
  • fix(pipeline): pipeline tasks can return multiple outputs to unpack

@jrs65 jrs65 requested a review from rikvl February 6, 2024 20:29
Copy link
Contributor

@rikvl rikvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope I understood what's going on here. If so, I think this only requires one or two small changes.

@ljgray ljgray mentioned this pull request May 1, 2024
1 task
@ljgray ljgray force-pushed the jrs/fix-pipeline-outputs branch 2 times, most recently from c5cb7f3 to 9a02bfa Compare August 2, 2024 22:12
@ljgray ljgray requested review from rikvl and ketiltrout August 2, 2024 22:12
@ljgray ljgray force-pushed the jrs/fix-pipeline-outputs branch from 9a02bfa to 86d3fa7 Compare August 6, 2024 17:50
@ljgray
Copy link
Contributor

ljgray commented Aug 6, 2024

The key functionality here was added in a different PR, so this is now just adding tests

Copy link
Member

@ketiltrout ketiltrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine.

Though, importing conftest directly, instead of just setting up a bunch of fixtures is a weird way of doing things. But I don't think this PR is the place to address that.

@ljgray ljgray merged commit 1b543a0 into master Aug 6, 2024
5 checks passed
@ljgray ljgray deleted the jrs/fix-pipeline-outputs branch August 6, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants