Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecated 'newbyteorder' and doctests #279

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Fix deprecated 'newbyteorder' and doctests #279

merged 2 commits into from
Sep 27, 2024

Conversation

ljgray
Copy link
Contributor

@ljgray ljgray commented Sep 27, 2024 •
edited
Loading

  • The previous implementation of newbyteorder is deprecated in numpy 2.0. This change is compatible with nump 1.xx and numpy 2.x
  • Minor doctest changes to handle new numpy scalar printing while maintaining compatibility with numpy 1.xx
    • These are slightly annoying but I'm not really sure how else to maintain compatibility

@ljgray ljgray changed the title Fix deprecated 'newbyteorder' Fix deprecated 'newbyteorder' and doctests Sep 27, 2024
@ljgray ljgray marked this pull request as ready for review September 27, 2024 00:54
@ljgray ljgray requested a review from ketiltrout September 27, 2024 00:54
ketiltrout
ketiltrout approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@ketiltrout ketiltrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if there's a solution here that isn't either at least a little annoying or unreasonable.

@ljgray ljgray merged commit 3d45c3d into master Sep 27, 2024
5 checks passed
@ljgray ljgray deleted the np-compat-fixes branch September 27, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ketiltrout ketiltrout ketiltrout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljgray @ketiltrout