Create a metaclass for Singleton's and remove pysingleton#494
Merged
fliiiix merged 1 commit intoradish-bdd:mainfrom Nov 14, 2025
Merged
Create a metaclass for Singleton's and remove pysingleton#494fliiiix merged 1 commit intoradish-bdd:mainfrom
fliiiix merged 1 commit intoradish-bdd:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #494 +/- ##
==========================================
+ Coverage 87.50% 87.53% +0.03%
==========================================
Files 38 38
Lines 2329 2335 +6
==========================================
+ Hits 2038 2044 +6
Misses 291 291
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if this is where you want the singleton Meta class to be (or the tests). This completely removes the pysingleton library. Closes #471 .
Added quick tests to prove that it replaces the old singleton.
(it was easier to create a new branch (old MR #492)