-
Notifications
You must be signed in to change notification settings - Fork 119
Single artifact helper #10272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Single artifact helper #10272
Conversation
Signed-off-by: Sylvain Niles <[email protected]>
Signed-off-by: Sylvain Niles <[email protected]>
Signed-off-by: Sylvain Niles <[email protected]>
4039509 to
93682a3
Compare
Signed-off-by: Sylvain Niles <[email protected]>
Signed-off-by: Sylvain Niles <[email protected]>
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Signed-off-by: Sylvain Niles <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10272 +/- ##
==========================================
- Coverage 50.42% 50.40% -0.02%
==========================================
Files 661 661
Lines 41072 41072
==========================================
- Hits 20709 20703 -6
- Misses 18399 18402 +3
- Partials 1964 1967 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Sylvain Niles <[email protected]>
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Signed-off-by: Sylvain Niles <[email protected]>
Signed-off-by: Sylvain Niles <[email protected]>
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Signed-off-by: Sylvain Niles <[email protected]>
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Signed-off-by: Sylvain Niles <[email protected]>
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Signed-off-by: Sylvain Niles <[email protected]>
Signed-off-by: Sylvain Niles <[email protected]>
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
|
maybe we are missing the approval workflow which will finally push these artifacts to GHCR. should this be a required step for a PR post running tests, so that edge always has the latest images?? |
That's out of scope for this change, isn't that a workflow triggered by merge to main? Running tests is completely separate from managing artifacts in GHCR. |
Signed-off-by: Brooke Hamilton <[email protected]>
Radius functional test overviewClick here to see the test run details
Test Status⌛ Building Radius and pushing container images for functional tests... |
brooke-hamilton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
| - name: Check out code | ||
| uses: actions/checkout@v5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - name: Check out code | |
| uses: actions/checkout@v5 | |
| - name: Check out code | |
| uses: actions/checkout@v5 | |
| with: | |
| submodules: recursive |
| | head -n1 \ | ||
| | cut -d" " -f1 | ||
| ) | ||
| POD_NAME=$(kubectl get pods -n radius-system -o jsonpath='{range .items[*]}{.metadata.name}{" "}{.spec.containers[*].name}{"\n"}{end}' | grep "ucp" | head -n1 | cut -d" " -f1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for the formatting changes in this section and the removal of the code comments?
| cache-dependency-path: go.sum | ||
| cache: true | ||
|
|
||
| - name: Pull images from GHCR or build locally (with fallback + controller check) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be duplicated code from functional-test-cloud.yaml. Could it be consolidated into a script or action?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need the purge-old-images.yaml workflow if we are no longer putting PR images into GHCR?
Description
This PR consolidates build/test workflows and artifacts, reduces registry pushes, enables local functional test parity, adds first‑party image purge, and introduces build metrics.
What changed:
Workflow architecture:
graph TD subgraph "Fork PR Context (Untrusted)" A[PR Created/Updated] --> B(build.yaml); B --> C{Build Images}; C --> D[Save Images as .tar]; D --> E[Upload Artifact 'container-images']; end subgraph "Main Repo Context (Trusted)" F[Maintainer Approves] --> G(functional-tests-approval.yaml); G --> H(functional-test-*.yaml); H --> I{Download Artifact 'container-images'}; I --> J[Load .tar Images into KinD]; J --> K[Run Functional Tests]; end E --> F;Security analysis:
Notes:
Type of change
Fixes: N/A
Contributor checklist
Please verify that the PR meets the following requirements, where applicable:
- [ ] Yes
- [x] Not applicable
- [ ] Yes
- [x] Not applicable
- [ ] Yes
- [x] Not applicable
- [ ] Yes
- [x] Not applicable
- [ ] Yes
- [x] Not applicable
- [ ] Yes
- [x] Not applicable