Skip to content

Conversation

@nellshamrell
Copy link

@nellshamrell nellshamrell commented Nov 18, 2025

  • changes the name of the downloaded bicep binary from "rad-bicep" to "bicep"

Description

This changes the name of the downloaded bicep binary from "rad-bicep" to "bicep"

Type of change

  • This pull request adds or changes features of Radius and has an approved issue (issue link required).

Fixes: #10383

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

Here is a link to the relevant docs PR radius-project/docs#1597

@nellshamrell nellshamrell requested review from a team as code owners November 18, 2025 22:57
- changes the name of the downloaded bicep binary from "rad-bicep" to "bicep"

Signed-off-by: Nell Shamrell <[email protected]>
@nellshamrell nellshamrell force-pushed the update-downloaded-bicep-binary-name branch from 9f63128 to 55566c8 Compare November 18, 2025 22:59
@nellshamrell nellshamrell changed the title Fixes: #10383 Fix name of bicep binary Nov 18, 2025
@sk593
Copy link
Contributor

sk593 commented Nov 18, 2025

Code change looks good! Just some comments on documentation and naming references in the repo :)

We have a few test scripts that might rely on the rad-bicep naming:

test-validate-bicep: ## Validates that all .bicep files compile cleanly

There are also references to rad-bicep in our install scripts and some code. I think it'd make sense to update that as part of this PR too. These are just a few references that I remember, but there might be others.

echo "Installing rad-bicep (\"rad bicep download\")..."

Write-Warning "`r`nFailed to install rad-bicep"

func runBicepRaw(args ...string) ([]byte, error) {

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.40%. Comparing base (f001d3c) to head (a5fa302).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10838   +/-   ##
=======================================
  Coverage   50.40%   50.40%           
=======================================
  Files         664      664           
  Lines       41279    41279           
=======================================
  Hits        20807    20807           
  Misses      18498    18498           
  Partials     1974     1974           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@radius-functional-tests
Copy link

radius-functional-tests bot commented Nov 19, 2025

Radius functional test overview

🔍 Go to test action run

Click here to see the test run details
Name Value
Repository nellshamrell/radius
Commit ref a5fa302
Unique ID funce9ce3b1889
Image tag pr-funce9ce3b1889
  • gotestsum 1.13.0
  • KinD: v0.29.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funce9ce3b1889
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funce9ce3b1889
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funce9ce3b1889
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funce9ce3b1889
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funce9ce3b1889
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Change downloaded bicep binary name to "bicep"

2 participants