Skip to content

check if phone number has opted out #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

devmtnaing
Copy link
Contributor

Refer to the issue id if any. Include the link to the issue. E.g:

Check if a phone number is opted out

Describe the changes made. What does this PR changes that might be critical. If any critical decisions have been made, make sure you explain the rationale for these decisions.

  • Added one more step to check phone number opted out or not before sending the actual message.

How does the implementation addresses the problem

After merging this, we are preventing calling send sms API call to SMS providers.

@devmtnaing devmtnaing requested a review from rjayroach as a code owner January 17, 2020 06:25
@devmtnaing devmtnaing changed the title Pw 2988 check if phone number has opted out check if phone number has opted out Jan 17, 2020
@devmtnaing
Copy link
Contributor Author

Could not really find the Twilio opted_out API documentation. They probably have it under some other API?

@devmtnaing devmtnaing requested a review from rpbaltazar January 17, 2020 06:27
@rpbaltazar
Copy link
Contributor

@devmtnaing ok. lets not worry about Twillio right now.
Can you please help me rebasing this from master, so i can close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants