Skip to content

Coerce test as cast type in SQL Server is varchar #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2025
Merged

Coerce test as cast type in SQL Server is varchar #1298

merged 1 commit into from
Feb 12, 2025

Conversation

aidanharan
Copy link
Contributor

@aidanharan aidanharan commented Feb 12, 2025 •
edited
Loading

Coerce test as cast type in SQL Server is varchar.

Fixes:

https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/13285243589/job/37092391764

  1) Failure:
ActiveRecord::ConnectionAdapters::SchemaCacheTest#test_yaml_load_8_0_dump_without_cast_type_still_get_the_right_one [/usr/local/bundle/bundler/gems/rails-d3e1fb41e9e2/activerecord/test/cases/connection_adapters/schema_cache_test.rb:195]:
Expected: :string
  Actual: :varchar

@aidanharan aidanharan marked this pull request as ready for review February 12, 2025 14:10
@aidanharan aidanharan merged commit 6e287b8 into main Feb 12, 2025
5 checks passed
@aidanharan aidanharan deleted the schema-cache-test-cast-type-varchar branch February 12, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rails-8.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aidanharan