Skip to content

Conversation

aidanharan
Copy link
Contributor

Include changes from rails/rails#54561

Fixes following tests.

https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/13449856684/job/37582307288#step:4:528

 1) Error:
UpdateAllTest#test_dynamic_update_all_with_two_joins_on_the_target:
ActiveRecord::StatementInvalid: TinyTds::Error: The multi-part identifier "developers.mentor_id" could not be bound.
    lib/active_record/connection_adapters/sqlserver/database_statements.rb:445:in 'TinyTds::Result#each'
    lib/active_record/connection_adapters/sqlserver/database_statements.rb:445:in 'ActiveRecord::ConnectionAdapters::SQLServer::DatabaseStatements#handle_to_names_and_values'

 2) Error:
UpdateAllTest#test_dynamic_update_all_with_a_through_join:
ActiveRecord::StatementInvalid: TinyTds::Error: The multi-part identifier "treasures.ship_id" could not be bound.
    lib/active_record/connection_adapters/sqlserver/database_statements.rb:445:in 'TinyTds::Result#each'
    lib/active_record/connection_adapters/sqlserver/database_statements.rb:445:in 'ActiveRecord::ConnectionAdapters::SQLServer::DatabaseStatements#handle_to_names_and_values'

@aidanharan aidanharan marked this pull request as ready for review February 21, 2025 20:54
@aidanharan aidanharan merged commit 212fb0a into main Feb 21, 2025
6 checks passed
@aidanharan aidanharan deleted the update-all-fixes branch February 21, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant