Skip to content

Foreign keys are expected in reverse order #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 8, 2025
Merged

Foreign keys are expected in reverse order #1349

merged 2 commits into from
Jul 8, 2025

Conversation

aidanharan
Copy link
Contributor

@aidanharan aidanharan commented Jul 7, 2025 •
edited
Loading

Foreign keys are expected in reversed order.

Fixes:

https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/16113377465/job/45461734371

  3) Failure:
ActiveRecord::Migration::CompatibilityTest#test_remove_foreign_key_on_8_0 [/usr/local/bundle/bundler/gems/rails-4621f7131d2a/activerecord/test/cases/migration/compatibility_test.rb:706]:
StandardError expected but nothing was raised.

Test added by rails/rails#55086

@aidanharan aidanharan marked this pull request as ready for review July 8, 2025 12:01
@aidanharan aidanharan merged commit 882842c into main Jul 8, 2025
3 of 6 checks passed
@aidanharan aidanharan deleted the remove-foreign-key-reverse branch July 8, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rails-8.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aidanharan