Skip to content

Conversation

aidanharan
Copy link
Contributor

Fix:

https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/16245249105/job/45867260988

1) Failure:
EachTest#test_in_batches_executes_range_queries_when_unconstrained [/usr/local/bundle/bundler/gems/rails-97dac99b5e80/activerecord/test/cases/batches_test.rb:646]:
0 instead of 1 queries were executed.
Queries:
EXEC sp_executesql N'SELECT [posts].[id] FROM [posts] ORDER BY [posts].[id] ASC OFFSET @0 ROWS FETCH NEXT @1 ROWS ONLY', N'@0 int, @1 int', @0 = 1, @1 = 1
EXEC sp_executesql N'SELECT [posts].[id] FROM [posts] WHERE [posts].[id] > @0 ORDER BY [posts].[id] ASC OFFSET @1 ROWS FETCH NEXT @2 ROWS ONLY', N'@0 bigint, @1 int, @2 int', @0 = 2, @1 = 1, @2 = 1
EXEC sp_executesql N'SELECT [posts].[id] FROM [posts] WHERE [posts].[id] > @0 ORDER BY [posts].[id] ASC OFFSET @1 ROWS FETCH NEXT @2 ROWS ONLY', N'@0 bigint, @1 int, @2 int', @0 = 4, @1 = 1, @2 = 1
EXEC sp_executesql N'SELECT [posts].[id] FROM [posts] WHERE [posts].[id] > @0 ORDER BY [posts].[id] ASC OFFSET @1 ROWS FETCH NEXT @2 ROWS ONLY', N'@0 bigint, @1 int, @2 int', @0 = 6, @1 = 1, @2 = 1
EXEC sp_executesql N'SELECT [posts].[id] FROM [posts] WHERE [posts].[id] > @0 ORDER BY [posts].[id] ASC OFFSET @1 ROWS FETCH NEXT @2 ROWS ONLY', N'@0 bigint, @1 int, @2 int', @0 = 8, @1 = 1, @2 = 1
EXEC sp_executesql N'SELECT [posts].[id] FROM [posts] WHERE [posts].[id] > @0 ORDER BY [posts].[id] ASC OFFSET @1 ROWS FETCH NEXT @2 ROWS ONLY', N'@0 bigint, @1 int, @2 int', @0 = 10, @1 = 1, @2 = 1
EXEC sp_executesql N'SELECT [posts].[id] FROM [posts] WHERE [posts].[id] > @0 ORDER BY [posts].[id] ASC OFFSET 0 ROWS FETCH NEXT @1 ROWS ONLY', N'@0 bigint, @1 int', @0 = 10, @1 = 2.
Expected: 1
  Actual: 0

  2) Failure:
EachTest#test_in_batches_executes_range_queries_when_constrained_and_opted_in_into_ranges [/usr/local/bundle/bundler/gems/rails-97dac99b5e80/activerecord/test/cases/batches_test.rb:684]:
0 instead of 1 queries were executed.
Queries:
EXEC sp_executesql N'SELECT [posts].[id] FROM [posts] WHERE (id < @0) ORDER BY [posts].[id] ASC OFFSET @1 ROWS FETCH NEXT @2 ROWS ONLY', N'@0 int, @1 int, @2 int', @0 = 5, @1 = 1, @2 = 1
EXEC sp_executesql N'SELECT [posts].[id] FROM [posts] WHERE (id < @0) AND [posts].[id] > @1 ORDER BY [posts].[id] ASC OFFSET @2 ROWS FETCH NEXT @3 ROWS ONLY', N'@0 int, @1 bigint, @2 int, @3 int', @0 = 5, @1 = 2, @2 = 1, @3 = 1
EXEC sp_executesql N'SELECT [posts].[id] FROM [posts] WHERE (id < @0) AND [posts].[id] > @1 ORDER BY [posts].[id] ASC OFFSET @2 ROWS FETCH NEXT @3 ROWS ONLY', N'@0 int, @1 bigint, @2 int, @3 int', @0 = 5, @1 = 4, @2 = 1, @3 = 1
EXEC sp_executesql N'SELECT [posts].[id] FROM [posts] WHERE (id < @0) AND [posts].[id] > @1 ORDER BY [posts].[id] ASC OFFSET 0 ROWS FETCH NEXT @2 ROWS ONLY', N'@0 int, @1 bigint, @2 int', @0 = 5, @1 = 4, @2 = 2.
Expected: 1
  Actual: 0

  3) Failure:
EachTest#test_in_batches_executes_in_queries_when_constrained [/usr/local/bundle/bundler/gems/rails-97dac99b5e80/activerecord/test/cases/batches_test.rb:672]:
0 instead of 3 queries were executed.
Queries:
EXEC sp_executesql N'SELECT [posts].[id] FROM [posts] WHERE (id < @0) ORDER BY [posts].[id] ASC OFFSET 0 ROWS FETCH NEXT @1 ROWS ONLY', N'@0 int, @1 int', @0 = 5, @1 = 2
EXEC sp_executesql N'SELECT [posts].[id] FROM [posts] WHERE (id < @0) AND [posts].[id] > @1 ORDER BY [posts].[id] ASC OFFSET 0 ROWS FETCH NEXT @2 ROWS ONLY', N'@0 int, @1 bigint, @2 int', @0 = 5, @1 = 2, @2 = 2
EXEC sp_executesql N'SELECT [posts].[id] FROM [posts] WHERE (id < @0) AND [posts].[id] > @1 ORDER BY [posts].[id] ASC OFFSET 0 ROWS FETCH NEXT @2 ROWS ONLY', N'@0 int, @1 bigint, @2 int', @0 = 5, @1 = 4, @2 = 2.
Expected: 3
  Actual: 0

  4) Failure:
EachTest#test_in_batches_executes_in_queries_when_unconstrained_and_opted_out_of_ranges [/usr/local/bundle/bundler/gems/rails-97dac99b5e80/activerecord/test/cases/batches_test.rb:660]:
0 instead of 6 queries were executed.
Queries:
EXEC sp_executesql N'SELECT [posts].[id] FROM [posts] ORDER BY [posts].[id] ASC OFFSET 0 ROWS FETCH NEXT @0 ROWS ONLY', N'@0 int', @0 = 2
EXEC sp_executesql N'SELECT [posts].[id] FROM [posts] WHERE [posts].[id] > @0 ORDER BY [posts].[id] ASC OFFSET 0 ROWS FETCH NEXT @1 ROWS ONLY', N'@0 bigint, @1 int', @0 = 2, @1 = 2
EXEC sp_executesql N'SELECT [posts].[id] FROM [posts] WHERE [posts].[id] > @0 ORDER BY [posts].[id] ASC OFFSET 0 ROWS FETCH NEXT @1 ROWS ONLY', N'@0 bigint, @1 int', @0 = 4, @1 = 2
EXEC sp_executesql N'SELECT [posts].[id] FROM [posts] WHERE [posts].[id] > @0 ORDER BY [posts].[id] ASC OFFSET 0 ROWS FETCH NEXT @1 ROWS ONLY', N'@0 bigint, @1 int', @0 = 6, @1 = 2
EXEC sp_executesql N'SELECT [posts].[id] FROM [posts] WHERE [posts].[id] > @0 ORDER BY [posts].[id] ASC OFFSET 0 ROWS FETCH NEXT @1 ROWS ONLY', N'@0 bigint, @1 int', @0 = 8, @1 = 2
EXEC sp_executesql N'SELECT [posts].[id] FROM [posts] WHERE [posts].[id] > @0 ORDER BY [posts].[id] ASC OFFSET 0 ROWS FETCH NEXT @1 ROWS ONLY', N'@0 bigint, @1 int', @0 = 10, @1 = 2.
Expected: 6
  Actual: 0

@aidanharan aidanharan marked this pull request as ready for review July 14, 2025 10:04
@aidanharan aidanharan merged commit 7d96477 into main Jul 14, 2025
2 of 6 checks passed
@aidanharan aidanharan deleted the coerce-batches-tests branch July 14, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant