add mapping fix for Harsh and Harsh Deep

[harsh183]

I noticed my contributions were showing up in two different places due to diferent name/email combos on two different machines:

https://contributors.rubyonrails.org/contributors/harsh-deep/commits

https://contributors.rubyonrails.org/contributors/harsh/commits

I guess long term it could be nice if they were based on GitHub usernames. Let me know if I got anything wrong here

[fxn]

Hey, I don't see a test for the email address, was there any commit associated with it?

[harsh183]

@fxn the test is in this PR with with a particular commit:

assert_contributor_names '5ff38f4', 'Harsh Deep'

This page is also working fine now: https://contributors.rubyonrails.org/contributors/harsh-deep/commits , earlier it was split up.

[fxn]

@harsh183 there is a test for "Harsh", but we should have a test for "harsh.deep\100moderntreasury.com" too. Was any commit associated with that email address?

[fxn]

Let me quote the docs:

Please take into account that these mappings are meant to connect handlers and friends which are present in the history. Add mappings only if the application has found the mapped string and you can write a test that fails for a particular commit otherwise, this is not a database of people's handlers.

If the email address got credit for some commit, we should add a test for it. Otherwise, we should delete it.