feat: add recurring cleanup job to generator #564
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @elasticspoon! And sorry for the delay, I skipped this PR because it was marked as draft, but I think it's ready! |
Its not immediately clear that finished jobs need to be cleaned up or that solid queue has a built in way to do that. This adds a commented out implementation of that recurring behavior to the generator to make is easier for users to learn about the behavior.
rosa
force-pushed
the
add-cleanup-job-to-generator
branch
from
b405ca8 to
4a95bd1
Compare
|
Thanks a lot @elasticspoon! Sorry for the delay, I'm finally catching up on PRs. I'm going to go with #562 but modified, so the job is actually run and not just commented out. |
Cool! I had this in draft cause I wasn't sure which is better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
At my work we have been trying to unify our applications on solid queue for background job processing and we found pretty consistently that when developers were setting it up they did not realize that they would need to schedule a job to clear out finished jobs. (I only learned about this when I had 12M finished jobs and my dashboard had slowed to a crawl).
Its not immediately clear that finished jobs need to be cleaned up or that solid queue has a built in way to do that. The only mention of this in the README is part of a bullet under additional config.
Implementation
I think adding a note and implementation of this behavior directly to the
recurring.ymlthat is generated when installing would make it a lot easier for developers to realize that they may need to add this recurring job.