Enable multi-tab debugger support for concurrent MCP clients#39
Open
elik-ru wants to merge 1 commit into
Open
Conversation
Previously, when switching tabs, the debugger would detach from the previous tab causing CDP commands to timeout. This was problematic when multiple MCP clients tried to use different tabs in the same browser. Changes: - Replace single debuggerAttached/currentDebuggerTabId with Set of attached tabs - Keep debuggers attached to all used tabs instead of detaching when switching - Update event listener to accept events from any attached tab - Track total attached tabs in log messages for debugging This allows multiple MCP clients to work on different tabs simultaneously without interfering with each other.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When two MCP clients tried to use different tabs in the same browser:
Solution
Instead of tracking a single debuggerAttached boolean and currentDebuggerTabId, we now use a Set of tabIds to track all tabs with debuggers attached. When switching tabs, we no longer detach from previous tabs - all debuggers stay active.
Test plan