-
-
Notifications
You must be signed in to change notification settings - Fork 28
Add more data to the compats table #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add more data to the compats table #125
Conversation
1. `rake data:update_rails_releases` | ||
2. `Gemmies::Create.call('rack')` | ||
3. After that you can visit `http://localhost:3000/gems/rack` and you can see the info. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We do not necessarily need to add this, but also maybe the correct title is
local setup
. - I would keep the
step 1
because when you set up locally, we need those Rails releases.step 2 and 3
are not necessary, given that they can be done by UI.
maximum_ruby_version: "3.4.2", | ||
minimum_bundler_version: "2.5.20", | ||
maximum_bundler_version: "2.5.20", | ||
minimum_rubygems_version: "3.2.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@etagwerker can you share with me the current Production values for Rails 8
? I'll copy paste here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mateusdeap, I have doubts because on this file, for Rails 7.2, we have, for example:
minimum_bundler_version: "2.5.20"
This PR adds more data to the compats table in order to resolve this issue #118.
compact.id
was added in the first column.Rails Release
was added in the third column.We can move if we prefer.
Seed Data
I added a section to the Readme called
seed data
to help with local setup that is outside of the original issue's scope.In parallel, I added Rails 8 to the list of Rails Releases