Adds --use-path-as-archive-prefix flag for correct uploading of project subdirs
#596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihovil Ilakovac <[email protected]>
|
We have to have a much shorter flag to enable the new behavior 😆 Lets hear some other options please. |
|
I think the shortest flag name I can come up with is |
|
How about instead of having the flag describe what it does technically, have it describe what it does for the user? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #595
It enables the users to provide the
--use-path-as-archive-prefixflag if they want to upload a project subdir while zipped with the subdir as archive root. This maintains the old behavior for existing users that didn't provide the flag.@brody192 let me know if I can improve the solution / code quality