Fixing TAMIL NUMBER TEN replacement #10
Conversation
num_to_words/__init__.py
Outdated
| @@ -29,9 +31,9 @@ def num_to_word(num, lang, separator=", ", combiner=" "): | |||
| for language in SUPPORTED_LANGUAGES: | |||
| for num_index in range(10): | |||
| num = num.replace(DIGITS_LANG_MAPPING[language][num_index], DIGITS_LANG_MAPPING["en"][num_index]) | |||
| if language == 'ta': | |||
There was a problem hiding this comment.
Please use exception.py file for the language specific exception
| @@ -29,9 +31,7 @@ def num_to_word(num, lang, separator=", ", combiner=" "): | |||
| for language in SUPPORTED_LANGUAGES: | |||
| for num_index in range(10): | |||
| num = num.replace(DIGITS_LANG_MAPPING[language][num_index], DIGITS_LANG_MAPPING["en"][num_index]) | |||
|
|
|||
| # Assert that input contains only integer number | |||
| assert num, "Input string is empty" | |||
There was a problem hiding this comment.
why the assertation has been removed?
There was a problem hiding this comment.
Above I added
if not num:
return ''to return empty string if provided.
|
|
||
| # Assert that input contains only integer number | ||
| assert num, "Input string is empty" | ||
| num = language_specific_exception(num, lang, combiner) |
There was a problem hiding this comment.
this function has been planned to handle exception after the conversation,
using this function does not feel right, we can have two function for the exception,
- one before the converstion (what you are trying to do)
- one after the conversation (what the function
language_specific_exceptionis currently doing)
| @@ -59,4 +59,6 @@ def occurs_at_end(piece): | |||
| for expt in exception_dict: | |||
| if occurs_at_end(expt): | |||
| words = words.replace(expt, exception_dict[expt]) | |||
| elif lang == "ta": | |||
There was a problem hiding this comment.
I see your point but I would keep things simple.
There are two school of though here.
In modern usage, the Tamil language predominantly uses the Hindu-Arabic numeral system, where "௧௦" (the combination of 1 and 0) is used to represent the number 10. The traditional Tamil numeral "௰" for 10 is less commonly used today and is primarily found in historical texts, inscriptions, and certain cultural or ceremonial contexts.
So, "௧௦" is more common than "௰" in contemporary usage.
(I might be wrong with my limited tamil knowledge, please attach some source if you think otherwise)
There was a problem hiding this comment.
I don't have an opinion there. I thought the digit symbol ten ௰ should be handled anyway since it exists.
Hello.
ifstatement for௰(TAMIL NUMBER TEN).return ''in case empty input.