Skip to content

fix(sleep): drop stale embeddings with non-modal dimension #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajkripal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(sleep): drop stale embeddings with non-modal dimension #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions core/sleep.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,15 @@ def _load_embedding_matrix(
logger.warning("sleep: skipped %d bad embeddings", bad)
if not vectors:
return [], np.array([])
# Filter to modal dimension so stale embeddings from old models don't crash np.array()
from collections import Counter
modal_dim = Counter(len(v) for v in vectors).most_common(1)[0][0]
dim_filtered = [(nid, v) for nid, v in zip(valid_ids, vectors) if len(v) == modal_dim]
dropped = len(vectors) - len(dim_filtered)
if dropped:
logger.warning("sleep: dropped %d embeddings with non-modal dimension (modal=%d)", dropped, modal_dim)
valid_ids = [nid for nid, _ in dim_filtered]
vectors = [v for _, v in dim_filtered]
return valid_ids, np.array(vectors)


Expand Down
Loading